dma: Drop syscalls

DMA syscalls as they were implemented were unsafe. Accepting a void* was
never acceptable as many things could not be verified about it.
Accepting a channel identifier meant that a user mode thread could
start/stop any DMA channel which in theory could be owned by any other
driver. This shouldn't be possible.

Signed-off-by: Tom Burdick <[email protected]>

Author: teburd

drivers/dma/CMakeLists.txt

@@ -13,7 +13,6 @@ zephyr_library_sources_ifdef(CONFIG_DMAMUX_STM32	dmamux_stm32.c)
 zephyr_library_sources_ifdef(CONFIG_DMA_DW		dma_dw.c dma_dw_common.c)
 zephyr_library_sources_ifdef(CONFIG_DMA_NIOS2_MSGDMA	dma_nios2_msgdma.c)
 zephyr_library_sources_ifdef(CONFIG_DMA_SAM0		dma_sam0.c)
-zephyr_library_sources_ifdef(CONFIG_USERSPACE		dma_handlers.c)
 zephyr_library_sources_ifdef(CONFIG_DMA_MCUX_EDMA	dma_mcux_edma.c)
 zephyr_library_sources_ifdef(CONFIG_DMA_MCUX_EDMA_V3	dma_mcux_edma.c)
 zephyr_library_sources_ifdef(CONFIG_DMA_MCUX_EDMA_V4	dma_mcux_edma.c)

drivers/dma/dma_handlers.c

@@ -451,9 +451,7 @@ static inline int dma_reload(const struct device *dev, uint32_t channel,
  * @retval 0 if successful.
  * @retval Negative errno code if failure.
  */
-__syscall int dma_start(const struct device *dev, uint32_t channel);
-
-static inline int z_impl_dma_start(const struct device *dev, uint32_t channel)
+static inline int dma_start(const struct device *dev, uint32_t channel)
 {
 	const struct dma_driver_api *api =
 		(const struct dma_driver_api *)dev->api;
@@ -479,9 +477,7 @@ static inline int z_impl_dma_start(const struct device *dev, uint32_t channel)
  * @retval 0 if successful.
  * @retval Negative errno code if failure.
  */
-__syscall int dma_stop(const struct device *dev, uint32_t channel);
-
-static inline int z_impl_dma_stop(const struct device *dev, uint32_t channel)
+static inline int dma_stop(const struct device *dev, uint32_t channel)
 {
 	const struct dma_driver_api *api =
 		(const struct dma_driver_api *)dev->api;
@@ -506,9 +502,7 @@ static inline int z_impl_dma_stop(const struct device *dev, uint32_t channel)
  * @retval -EINVAL If invalid channel id or state.
  * @retval -errno Other negative errno code failure.
  */
-__syscall int dma_suspend(const struct device *dev, uint32_t channel);
-
-static inline int z_impl_dma_suspend(const struct device *dev, uint32_t channel)
+static inline int dma_suspend(const struct device *dev, uint32_t channel)
 {
 	const struct dma_driver_api *api = (const struct dma_driver_api *)dev->api;
 
@@ -534,9 +528,7 @@ static inline int z_impl_dma_suspend(const struct device *dev, uint32_t channel)
  * @retval -EINVAL If invalid channel id or state.
  * @retval -errno Other negative errno code failure.
  */
-__syscall int dma_resume(const struct device *dev, uint32_t channel);
-
-static inline int z_impl_dma_resume(const struct device *dev, uint32_t channel)
+static inline int dma_resume(const struct device *dev, uint32_t channel)
 {
 	const struct dma_driver_api *api = (const struct dma_driver_api *)dev->api;
 
@@ -562,11 +554,7 @@ static inline int z_impl_dma_resume(const struct device *dev, uint32_t channel)
  * @retval dma channel if successful.
  * @retval Negative errno code if failure.
  */
-__syscall int dma_request_channel(const struct device *dev,
-				  void *filter_param);
-
-static inline int z_impl_dma_request_channel(const struct device *dev,
-					     void *filter_param)
+static inline int dma_request_channel(const struct device *dev, void *filter_param)
 {
 	int i = 0;
 	int channel = -EINVAL;
@@ -607,11 +595,7 @@ static inline int z_impl_dma_request_channel(const struct device *dev,
  * @param channel  channel number
  *
  */
-__syscall void dma_release_channel(const struct device *dev,
-				   uint32_t channel);
-
-static inline void z_impl_dma_release_channel(const struct device *dev,
-					      uint32_t channel)
+static inline void dma_release_channel(const struct device *dev, uint32_t channel)
 {
 	const struct dma_driver_api *api =
 		(const struct dma_driver_api *)dev->api;
@@ -643,11 +627,7 @@ static inline void z_impl_dma_release_channel(const struct device *dev,
  * @retval Negative errno code if not support
  *
  */
-__syscall int dma_chan_filter(const struct device *dev,
-				   int channel, void *filter_param);
-
-static inline int z_impl_dma_chan_filter(const struct device *dev,
-					      int channel, void *filter_param)
+static inline int dma_chan_filter(const struct device *dev, int channel, void *filter_param)
 {
 	const struct dma_driver_api *api =
 		(const struct dma_driver_api *)dev->api;
@@ -812,6 +792,4 @@ static inline uint32_t dma_burst_index(uint32_t burst)
 }
 #endif
 
-#include <zephyr/syscalls/dma.h>
-
 #endif /* ZEPHYR_INCLUDE_DRIVERS_DMA_H_ */