sys: cbprintf: logging: fix equivalent branches in argify macro

stgloorious · cfriedt · commit ea499caa25e5 · 2025-10-03T21:19:47.000-04:00
The ((0) ? (arg) : (arg)) compiler trick leads to a codechecker
violation:

"conditional operator with identical true and false expressions"

Replace it by ((0) ? (0) : (arg)) to work around this issue.

Signed-off-by: Stefan Gloor &lt;stefan.gloor@siemens.com&gt;
diff --git a/include/zephyr/sys/cbprintf_internal.h b/include/zephyr/sys/cbprintf_internal.h
@@ -86,7 +86,7 @@ extern "C" {
  * opaque struct pointers. Alternative is to add + 0 but that requires suppressing
  * compiler warning about pointer arithmetic and does not cover opaque structs.
  */
-#define Z_ARGIFY(arg) ((0) ? (arg) : (arg))
+#define Z_ARGIFY(arg) ((0) ? 0 : (arg))
 
 /** @brief Return 1 if argument is a pointer to char or wchar_t
  *

Original file line number	Diff line number	Diff line change
`@@ -86,7 +86,7 @@ extern "C" {`
`86`	`86`	`* opaque struct pointers. Alternative is to add + 0 but that requires suppressing`
`87`	`87`	`* compiler warning about pointer arithmetic and does not cover opaque structs.`
`88`	`88`	`*/`
`89`		`-#define Z_ARGIFY(arg) ((0) ? (arg) : (arg))`
	`89`	`+#define Z_ARGIFY(arg) ((0) ? 0 : (arg))`
`90`	`90`
`91`	`91`	`/** @brief Return 1 if argument is a pointer to char or wchar_t`
`92`	`92`	`*`