samples: cmsis: philosophers: rename 'fork' to avoid POSIX conflict

There is a macro, `fork()`, inside of the philosophers example that
conflicts with the POSIX `fork()` function.

Since it is customary to avoid using reserved names, adjust the sample
so that the macro in question is called `philosopher_fork()`.

Signed-off-by: Chris Friedt <[email protected]>

Author: cfriedt

samples/subsys/portability/cmsis_rtos_v1/philosophers/src/main.c

@@ -69,7 +69,7 @@
 /***************************************/
 osSemaphoreId forks[NUM_PHIL];
 
-#define fork(x) (forks[x])
+#define philosopher_fork(x) (forks[x])
 
 /*
  * CMSIS limits the stack size, but qemu_x86_64, qemu_xtensa (all),
@@ -149,11 +149,11 @@ void philosopher(void const *id)
 
 	/* Djkstra's solution: always pick up the lowest numbered fork first */
 	if (is_last_philosopher(my_id)) {
-		fork1 = fork(0);
-		fork2 = fork(my_id);
+		fork1 = philosopher_fork(0);
+		fork2 = philosopher_fork(my_id);
 	} else {
-		fork1 = fork(my_id);
-		fork2 = fork(my_id + 1);
+		fork1 = philosopher_fork(my_id);
+		fork2 = philosopher_fork(my_id + 1);
 	}
 
 	while (1) {

samples/subsys/portability/cmsis_rtos_v2/philosophers/src/main.c

@@ -65,7 +65,7 @@
 /***************************************/
 osSemaphoreId_t forks[NUM_PHIL];
 
-#define fork(x) (forks[x])
+#define philosopher_fork(x) (forks[x])
 
 #define STACK_SIZE CONFIG_CMSIS_V2_THREAD_MAX_STACK_SIZE
 static K_THREAD_STACK_ARRAY_DEFINE(stacks, NUM_PHIL, STACK_SIZE);
@@ -174,11 +174,11 @@ void philosopher(void *id)
 
 	/* Djkstra's solution: always pick up the lowest numbered fork first */
 	if (is_last_philosopher(my_id)) {
-		fork1 = fork(0);
-		fork2 = fork(my_id);
+		fork1 = philosopher_fork(0);
+		fork2 = philosopher_fork(my_id);
 	} else {
-		fork1 = fork(my_id);
-		fork2 = fork(my_id + 1);
+		fork1 = philosopher_fork(my_id);
+		fork2 = philosopher_fork(my_id + 1);
 	}
 
 	while (1) {