Bluetooth: Mesh: Drop PENDING_RESET flag without checking it

PavelVPV · nashif · commit ee548488cc2c · 2023-06-02T18:57:14.000-04:00
Just drop PENDING_RESET flag without checking it. Coverity-CID: 316394, GitHub issue #58530 Signed-off-by: Pavel Vasilyev <pavel.vasilyev@nordicsemi.no>
diff --git a/subsys/bluetooth/mesh/rpl.c b/subsys/bluetooth/mesh/rpl.c
@@ -398,7 +398,7 @@ void bt_mesh_rpl_pending_store(uint16_t addr)
 		}
 	}
 
-	atomic_test_and_clear_bit(&rpl_flags, PENDING_RESET);
+	atomic_clear_bit(&rpl_flags, PENDING_RESET);
 
 	if (addr == BT_MESH_ADDR_ALL_NODES) {
 		(void)memset(&replay_list[last - shift + 1], 0, sizeof(struct bt_mesh_rpl) * shift);

Original file line number	Diff line number	Diff line change
`@@ -398,7 +398,7 @@ void bt_mesh_rpl_pending_store(uint16_t addr)`
`398`	`398`	`}`
`399`	`399`	`}`
`400`	`400`
`401`		`- atomic_test_and_clear_bit(&rpl_flags, PENDING_RESET);`
	`401`	`+ atomic_clear_bit(&rpl_flags, PENDING_RESET);`
`402`	`402`
`403`	`403`	`if (addr == BT_MESH_ADDR_ALL_NODES) {`
`404`	`404`	`(void)memset(&replay_list[last - shift + 1], 0, sizeof(struct bt_mesh_rpl) * shift);`