shell: modules: kernel_service: Fix log_level command

nordic-krch · kartben · commit f0cdaace22ec · 2025-01-16T14:46:33.000+01:00
Add missing return when input logging source argument is not valid.

Signed-off-by: Krzysztof Chruściński &lt;krzysztof.chruscinski@nordicsemi.no&gt;
diff --git a/subsys/shell/modules/kernel_service/log-level.c b/subsys/shell/modules/kernel_service/log-level.c
@@ -34,6 +34,7 @@ static int cmd_kernel_log_level_set(const struct shell *sh, size_t argc, char **
 	/* log_filter_set() takes an int16_t for the source ID */
 	if (source_id < 0) {
 		shell_error(sh, "Unable to find log source: %s", argv[1]);
+		return -EINVAL;
 	}
 
 	log_filter_set(NULL, 0, (int16_t)source_id, severity);

Original file line number	Diff line number	Diff line change
`@@ -34,6 +34,7 @@ static int cmd_kernel_log_level_set(const struct shell sh, size_t argc, char *`
`34`	`34`	`/* log_filter_set() takes an int16_t for the source ID */`
`35`	`35`	`if (source_id < 0) {`
`36`	`36`	`shell_error(sh, "Unable to find log source: %s", argv[1]);`
	`37`	`+ return -EINVAL;`
`37`	`38`	`}`
`38`	`39`
`39`	`40`	`log_filter_set(NULL, 0, (int16_t)source_id, severity);`