drivers: ieee802154: properly announce promisc mode

Most IEEE 802.15.4 drivers do not support promiscuous mode, some do.
There is a dedicated L2 flag to signal this capability to clients.

Unfortunately the IEEE 802.15.4 L2 stack does not announce this flag
even for drivers that correctly expose it in their HW capabilities.
Some clients (notably the OpenThread L2) even uses promiscuous mode
without checking whether the driver actually supports it.

This change lets the vanilla IEEE 802.15.4 L2 check the driver's
HW capabilities to announce promiscuous mode on its 'get_flags()'
interface if supported.

The OpenThread L2 uses a constant (potentially incorrect) response
to 'get_flags()'. Fixing the OpenThread L2 is out of scope of this
change. This change just introduces TODO messages to the OpenThread code
so that the OpenThread team may fix the issue (or delete the TODO if they
deem it irrelevant).

Fixes: #51263

Signed-off-by: Florian Grandel <[email protected]>

Author: Florian Grandel

modules/openthread/platform/radio.c

@@ -808,6 +808,10 @@ void otPlatRadioSetPromiscuous(otInstance *aInstance, bool aEnable)
 	LOG_DBG("PromiscuousMode=%d", aEnable ? 1 : 0);
 
 	promiscuous = aEnable;
+	/* TODO: Should check whether the radio driver actually supports
+	 *       promiscuous mode, see net_if_l2(iface)->get_flags() and
+	 *       ieee802154_get_hw_capabilities(iface).
+	 */
 	radio_api->configure(radio_dev, IEEE802154_CONFIG_PROMISCUOUS, &config);
 }
 

subsys/net/l2/ieee802154/ieee802154.c

@@ -431,6 +431,9 @@ void ieee802154_init(struct net_if *iface)
 	 */
 	ctx->channel = IEEE802154_NO_CHANNEL;
 	ctx->flags = NET_L2_MULTICAST;
+	if (ieee802154_get_hw_capabilities(iface) & IEEE802154_HW_PROMISC) {
+		ctx->flags |= NET_L2_PROMISC_MODE;
+	}
 
 	ctx->short_addr = IEEE802154_SHORT_ADDRESS_NOT_ASSOCIATED;
 	sys_memcpy_swap(ctx->ext_addr, eui64_be, IEEE802154_EXT_ADDR_LENGTH);

subsys/net/l2/openthread/openthread.c

@@ -540,6 +540,9 @@ void ieee802154_init(struct net_if *iface)
 
 static enum net_l2_flags openthread_flags(struct net_if *iface)
 {
+	/* TODO: Should report NET_L2_PROMISC_MODE if the radio driver
+	 *       reports the IEEE802154_HW_PROMISC capability.
+	 */
 	return NET_L2_MULTICAST | NET_L2_MULTICAST_SKIP_JOIN_SOLICIT_NODE;
 }