cmake: make extra_post_build_* target properties

Move extra_post_build_command and extra_post_build_byproducts to
ZEPHYR_TARGET instead of using globals. Make some whitespace
adjustments while we are here to make it clearer (to grep) when we are
using the property and when we are using the variable by the same
name.

Signed-off-by: Marti Bolivar <[email protected]>

Author: mbolivar-nordic

CMakeLists.txt

@@ -1428,25 +1428,15 @@ if(CONFIG_BUILD_OUTPUT_EXE)
     )
 endif()
 
-get_property(extra_post_build_commands
-  GLOBAL PROPERTY
-  extra_post_build_commands
-  )
-
-list(APPEND
-  post_build_commands
-  ${extra_post_build_commands}
-  )
-
-get_property(extra_post_build_byproducts
-  GLOBAL PROPERTY
-  extra_post_build_byproducts
-  )
+get_target_property(extra_post_build_commands ${ZEPHYR_TARGET} extra_post_build_commands)
+if(extra_post_build_commands)
+  list(APPEND post_build_commands ${extra_post_build_commands})
+endif()
 
-list(APPEND
-  post_build_byproducts
-  ${extra_post_build_byproducts}
-  )
+get_target_property(extra_post_build_byproducts ${ZEPHYR_TARGET} extra_post_build_byproducts)
+if(extra_post_build_byproducts)
+  list(APPEND post_build_byproducts ${extra_post_build_byproducts})
+endif()
 
 # Add post_build_commands to post-process the final .elf file produced by
 # either the ZEPHYR_PREBUILT_EXECUTABLE or the KERNEL_ELF executable

arch/arm/core/cortex_m/tz/CMakeLists.txt

@@ -20,9 +20,7 @@ if(CONFIG_ARM_FIRMWARE_HAS_SECURE_ENTRY_FUNCS)
   )
 
   # Indicate that the entry veneers library file is created during linking of this firmware.
-  set_property(
-    GLOBAL APPEND PROPERTY
-    extra_post_build_byproducts
+  set_property(TARGET ${ZEPHYR_TARGET} APPEND PROPERTY extra_post_build_byproducts
     ${CMAKE_BINARY_DIR}/${CONFIG_ARM_ENTRY_VENEERS_LIB_NAME}
     )
 endif()

boards/xtensa/intel_s1000_crb/CMakeLists.txt

@@ -5,7 +5,7 @@ if(CONFIG_PINMUX_INTEL_S1000)
   zephyr_library_sources(pinmux.c)
 endif()
 
-set_property(GLOBAL APPEND PROPERTY extra_post_build_commands
+set_property(TARGET ${ZEPHYR_TARGET} APPEND PROPERTY extra_post_build_commands
   COMMAND ${PYTHON_EXECUTABLE} ${BOARD_DIR}/support/create_board_img.py
   -i ${PROJECT_BINARY_DIR}/${CONFIG_KERNEL_BIN_NAME}.bin
   -o ${PROJECT_BINARY_DIR}/${CONFIG_KERNEL_BIN_NAME}_${BOARD}.bin