Skip to content

Commit f49bb10

Browse files
joerchancarlescufi
authored andcommitted
Bluetooth: Samples: Switch to synchronous bt_init before main loop
Switch to using the synchronous bt_init call before starting the main loop in the peripheral samples. This is to avoid sending notifications before bluetooth has been properly initialized. Signed-off-by: Joakim Andersson <[email protected]>
1 parent cbf666e commit f49bb10

File tree

6 files changed

+30
-36
lines changed

6 files changed

+30
-36
lines changed

samples/bluetooth/peripheral/src/main.c

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -245,12 +245,9 @@ static struct bt_conn_cb conn_callbacks = {
245245
.disconnected = disconnected,
246246
};
247247

248-
static void bt_ready(int err)
248+
static void bt_ready(void)
249249
{
250-
if (err) {
251-
printk("Bluetooth init failed (err %d)\n", err);
252-
return;
253-
}
250+
int err;
254251

255252
printk("Bluetooth initialized\n");
256253

@@ -323,12 +320,14 @@ void main(void)
323320
{
324321
int err;
325322

326-
err = bt_enable(bt_ready);
323+
err = bt_enable(NULL);
327324
if (err) {
328325
printk("Bluetooth init failed (err %d)\n", err);
329326
return;
330327
}
331328

329+
bt_ready();
330+
332331
bt_conn_cb_register(&conn_callbacks);
333332
bt_conn_auth_cb_register(&auth_cb_display);
334333

samples/bluetooth/peripheral_csc/src/main.c

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -365,12 +365,9 @@ static const struct bt_data ad[] = {
365365
BT_DATA_BYTES(BT_DATA_UUID16_ALL, 0x16, 0x18, 0x0f, 0x18),
366366
};
367367

368-
static void bt_ready(int err)
368+
static void bt_ready(void)
369369
{
370-
if (err) {
371-
printk("Bluetooth init failed (err %d)\n", err);
372-
return;
373-
}
370+
int err;
374371

375372
printk("Bluetooth initialized\n");
376373

@@ -400,12 +397,14 @@ void main(void)
400397
{
401398
int err;
402399

403-
err = bt_enable(bt_ready);
400+
err = bt_enable(NULL);
404401
if (err) {
405402
printk("Bluetooth init failed (err %d)\n", err);
406403
return;
407404
}
408405

406+
bt_ready();
407+
409408
bt_conn_cb_register(&conn_callbacks);
410409

411410
while (1) {

samples/bluetooth/peripheral_esp/src/main.c

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -378,12 +378,9 @@ static struct bt_conn_cb conn_callbacks = {
378378
.disconnected = disconnected,
379379
};
380380

381-
static void bt_ready(int err)
381+
static void bt_ready(void)
382382
{
383-
if (err) {
384-
printk("Bluetooth init failed (err %d)\n", err);
385-
return;
386-
}
383+
int err;
387384

388385
printk("Bluetooth initialized\n");
389386

@@ -437,12 +434,14 @@ void main(void)
437434
{
438435
int err;
439436

440-
err = bt_enable(bt_ready);
437+
err = bt_enable(NULL);
441438
if (err) {
442439
printk("Bluetooth init failed (err %d)\n", err);
443440
return;
444441
}
445442

443+
bt_ready();
444+
446445
bt_conn_cb_register(&conn_callbacks);
447446
bt_conn_auth_cb_register(&auth_cb_display);
448447

samples/bluetooth/peripheral_hr/src/main.c

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -54,12 +54,9 @@ static struct bt_conn_cb conn_callbacks = {
5454
.disconnected = disconnected,
5555
};
5656

57-
static void bt_ready(int err)
57+
static void bt_ready(void)
5858
{
59-
if (err) {
60-
printk("Bluetooth init failed (err %d)\n", err);
61-
return;
62-
}
59+
int err;
6360

6461
printk("Bluetooth initialized\n");
6562

@@ -115,12 +112,14 @@ void main(void)
115112
{
116113
int err;
117114

118-
err = bt_enable(bt_ready);
115+
err = bt_enable(NULL);
119116
if (err) {
120117
printk("Bluetooth init failed (err %d)\n", err);
121118
return;
122119
}
123120

121+
bt_ready();
122+
124123
bt_conn_cb_register(&conn_callbacks);
125124
bt_conn_auth_cb_register(&auth_cb_display);
126125

samples/bluetooth/peripheral_ht/src/main.c

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -58,12 +58,9 @@ static struct bt_conn_cb conn_callbacks = {
5858
.disconnected = disconnected,
5959
};
6060

61-
static void bt_ready(int err)
61+
static void bt_ready(void)
6262
{
63-
if (err) {
64-
printk("Bluetooth init failed (err %d)\n", err);
65-
return;
66-
}
63+
int err;
6764

6865
printk("Bluetooth initialized\n");
6966

@@ -108,12 +105,14 @@ void main(void)
108105
{
109106
int err;
110107

111-
err = bt_enable(bt_ready);
108+
err = bt_enable(NULL);
112109
if (err) {
113110
printk("Bluetooth init failed (err %d)\n", err);
114111
return;
115112
}
116113

114+
bt_ready();
115+
117116
bt_conn_cb_register(&conn_callbacks);
118117
bt_conn_auth_cb_register(&auth_cb_display);
119118

tests/bluetooth/bsim_bt/bsim_test_app/src/test_connect2.c

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -99,12 +99,9 @@ static struct bt_conn_cb conn_callbacks = {
9999
.disconnected = disconnected,
100100
};
101101

102-
static void bt_ready(int err)
102+
static void bt_ready(void)
103103
{
104-
if (err) {
105-
FAIL("Bluetooth init failed (err %d)\n", err);
106-
return;
107-
}
104+
int err;
108105

109106
printk("Bluetooth initialized\n");
110107

@@ -148,12 +145,14 @@ static void test_con2_main(void)
148145
static int notify_count;
149146
int err;
150147

151-
err = bt_enable(bt_ready);
148+
err = bt_enable(NULL);
152149
if (err) {
153150
FAIL("Bluetooth init failed (err %d)\n", err);
154151
return;
155152
}
156153

154+
bt_ready();
155+
157156
bt_conn_cb_register(&conn_callbacks);
158157

159158
/* Implement notification. At the moment there is no suitable way

0 commit comments

Comments
 (0)