Skip to content

Commit f5434c1

Browse files
JordanYateskartben
authored andcommitted
sensor: tmp108: use common sensor_value_ helpers
Use the common `sensor_value_*` helper functions instead of implementing the conversions again in the driver. Signed-off-by: Jordan Yates <[email protected]>
1 parent eefbed2 commit f5434c1

File tree

1 file changed

+3
-6
lines changed

1 file changed

+3
-6
lines changed

drivers/sensor/ti/tmp108/tmp108.c

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -153,10 +153,7 @@ static int tmp108_channel_get(const struct device *dev,
153153
}
154154

155155
uval = ((int32_t)drv_data->sample * TMP108_TEMP_MULTIPLIER(dev)) / TMP108_TEMP_DIVISOR(dev);
156-
val->val1 = uval / 1000000;
157-
val->val2 = uval % 1000000;
158-
159-
return 0;
156+
return sensor_value_from_micro(val, uval);
160157
}
161158

162159
static int tmp108_attr_get(const struct device *dev,
@@ -236,15 +233,15 @@ static int tmp108_attr_set(const struct device *dev,
236233
break;
237234

238235
case SENSOR_ATTR_LOWER_THRESH:
239-
uval = val->val1 * 1000000 + val->val2;
236+
uval = sensor_value_to_micro(val);
240237
reg_value = (uval * TMP108_TEMP_DIVISOR(dev)) / TMP108_TEMP_MULTIPLIER(dev);
241238
result = tmp108_reg_write(dev,
242239
TI_TMP108_REG_LOW_LIMIT,
243240
reg_value);
244241
break;
245242

246243
case SENSOR_ATTR_UPPER_THRESH:
247-
uval = val->val1 * 1000000 + val->val2;
244+
uval = sensor_value_to_micro(val);
248245
reg_value = (uval * TMP108_TEMP_DIVISOR(dev)) / TMP108_TEMP_MULTIPLIER(dev);
249246
result = tmp108_reg_write(dev,
250247
TI_TMP108_REG_HIGH_LIMIT,

0 commit comments

Comments
 (0)