dap: do not return error in DAP connect command

Johan Carlsson · aescolar · commit f5ccc3c82ccd · 2024-06-14T11:14:17.000+02:00
If a host client crashes or fails to disconnect, the probe will
hang. Allow a new connection without raising errors.

Signed-off-by: Johan Carlsson &lt;johan.carlsson@teenage.engineering&gt;
Signed-off-by: Johann Fischer &lt;johann.fischer@nordicsemi.no&gt;
diff --git a/subsys/dap/cmsis_dap.c b/subsys/dap/cmsis_dap.c
@@ -153,7 +153,6 @@ static uint16_t dap_connect(struct dap_context *const ctx,
 		if (atomic_test_and_set_bit(&ctx->state,
 					    DAP_STATE_CONNECTED)) {
 			LOG_ERR("DAP device is already connected");
-			port = DAP_ERROR;
 			break;
 		}
 

Original file line number	Diff line number	Diff line change
`@@ -153,7 +153,6 @@ static uint16_t dap_connect(struct dap_context *const ctx,`
`153`	`153`	`if (atomic_test_and_set_bit(&ctx->state,`
`154`	`154`	`DAP_STATE_CONNECTED)) {`
`155`	`155`	`LOG_ERR("DAP device is already connected");`
`156`		`- port = DAP_ERROR;`
`157`	`156`	`break;`
`158`	`157`	`}`
`159`	`158`