Skip to content

Commit f7e64c8

Browse files
d3zd3zmmahadevan108
authored andcommitted
drivers: serial: rpi_pico: Enable uart FIFO
A few lines above this change explicitly enable the UART FIFO. Then this line, goes and disables it. This seems to be from a workaround where the parity and stop bits are not coming in correctly in the config. Fixing that will be another patch. But, the FIFO should always be enabled. This is visible when trying to use bit rates that are reasonably fast. Even in IRQ mode, with a sufficient bit rate, bytes are readily dropped. Tested on a Sparkfun Promicro rp2040 board. Signed-off-by: David Brown <[email protected]>
1 parent d4dc516 commit f7e64c8

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

drivers/serial/uart_rpi_pico.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -191,7 +191,6 @@ static int uart_rpi_init(const struct device *dev)
191191
data->uart_config.parity = UART_CFG_PARITY_NONE;
192192
data->uart_config.stop_bits = UART_CFG_STOP_BITS_1;
193193
uart_rpi_set_format(dev, &data->uart_config);
194-
hw_clear_bits(&uart_hw->lcr_h, UART_UARTLCR_H_FEN_BITS);
195194
uart_hw->dr = 0U;
196195

197196
if (data->uart_config.flow_ctrl == UART_CFG_FLOW_CTRL_RTS_CTS) {

0 commit comments

Comments
 (0)