pm: device: do not allow suspending a turned off device

gmarull · cfriedt · commit f93778f2d2b1 · 2021-08-07T19:59:48.000-04:00
A device that is turned off should not be suspended. A device that has
been turned off can only be resumed. This action is currently forbidden
by the "should_suspend" function in the device PM code.

Signed-off-by: Gerard Marull-Paretas &lt;gerard.marull@nordicsemi.no&gt;
diff --git a/subsys/pm/device.c b/subsys/pm/device.c
@@ -145,6 +145,8 @@ int pm_device_state_set(const struct device *dev,
 		if ((dev->pm->state == PM_DEVICE_STATE_SUSPENDED) ||
 		    (dev->pm->state == PM_DEVICE_STATE_SUSPENDING)) {
 			return -EALREADY;
+		} else if (dev->pm->state == PM_DEVICE_STATE_OFF) {
+			return -ENOTSUP;
 		}
 
 		action = PM_DEVICE_ACTION_SUSPEND;

Original file line number	Diff line number	Diff line change
`@@ -145,6 +145,8 @@ int pm_device_state_set(const struct device *dev,`
`145`	`145`	`if ((dev->pm->state == PM_DEVICE_STATE_SUSPENDED) \|\|`
`146`	`146`	`(dev->pm->state == PM_DEVICE_STATE_SUSPENDING)) {`
`147`	`147`	`return -EALREADY;`
	`148`	`+ } else if (dev->pm->state == PM_DEVICE_STATE_OFF) {`
	`149`	`+ return -ENOTSUP;`
`148`	`150`	`}`
`149`	`151`
`150`	`152`	`action = PM_DEVICE_ACTION_SUSPEND;`