Skip to content

Commit f9739ab

Browse files
committed
python: Fix the requirement for libmagic to be installed
The Python python-magic module that we install for compliance checks requires libmagic to be installed on the system to work. This requires extra OS packages on Ubuntu and macOS, and an extra wheel on Windows. Signed-off-by: Carles Cufi <[email protected]>
1 parent cceb3e4 commit f9739ab

File tree

3 files changed

+4
-3
lines changed

3 files changed

+4
-3
lines changed

doc/develop/getting_started/index.rst

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,7 @@ The current minimum required version for the main dependencies are:
9393
sudo apt install --no-install-recommends git cmake ninja-build gperf \
9494
ccache dfu-util device-tree-compiler wget \
9595
python3-dev python3-pip python3-setuptools python3-tk python3-wheel xz-utils file \
96-
make gcc gcc-multilib g++-multilib libsdl2-dev
96+
make gcc gcc-multilib g++-multilib libsdl2-dev libmagic1
9797
9898
#. Verify the versions of the main dependencies installed on your system by entering::
9999

@@ -119,7 +119,7 @@ The current minimum required version for the main dependencies are:
119119

120120
.. code-block:: bash
121121
122-
brew install cmake ninja gperf python3 ccache qemu dtc wget
122+
brew install cmake ninja gperf python3 ccache qemu dtc wget libmagic
123123
124124
.. group-tab:: Windows
125125

doc/develop/getting_started/installation_linux.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ need one.
7979
sudo apt-get install --no-install-recommends git cmake ninja-build gperf \
8080
ccache dfu-util device-tree-compiler wget \
8181
python3-dev python3-pip python3-setuptools python3-tk python3-wheel xz-utils file libpython3.8-dev \
82-
make gcc gcc-multilib g++-multilib libsdl2-dev
82+
make gcc gcc-multilib g++-multilib libsdl2-dev libmagic1
8383
8484
.. group-tab:: Fedora
8585

scripts/requirements-compliance.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,5 +2,6 @@
22

33
# used by ci/check_compliance
44
python-magic
5+
python-magic-bin; sys_platform == "win32"
56
junitparser<2
67
pylint

0 commit comments

Comments
 (0)