Bluetooth: Audio: Fix return code in PACS notify

fredrikdanebjer · jhedberg · commit fefbb28edb36 · 2023-10-06T17:43:08.000+03:00
Fix errenous return value in pacs_gatt_notify function. The function
would always return zero, and not forward the error correctly.

Signed-off-by: Fredrik Danebjer &lt;frdn@demant.com&gt;
diff --git a/subsys/bluetooth/audio/pacs.c b/subsys/bluetooth/audio/pacs.c
@@ -795,11 +795,11 @@ static int pacs_gatt_notify(struct bt_conn *conn,
 		atomic_clear(&notify_rdy);
 	}
 
-	if (err == -ENOTCONN) {
-		return 0;
-	} else {
-		return 0;
+	if (err && err != -ENOTCONN) {
+		return err;
 	}
+
+	return 0;
 }
 
 static void notify_cb(struct bt_conn *conn, void *data)

Original file line number	Diff line number	Diff line change
`@@ -795,11 +795,11 @@ static int pacs_gatt_notify(struct bt_conn *conn,`
`795`	`795`	`atomic_clear(&notify_rdy);`
`796`	`796`	`}`
`797`	`797`
`798`		`- if (err == -ENOTCONN) {`
`799`		`- return 0;`
`800`		`- } else {`
`801`		`- return 0;`
	`798`	`+ if (err && err != -ENOTCONN) {`
	`799`	`+ return err;`
`802`	`800`	`}`
	`801`	`+`
	`802`	`+ return 0;`
`803`	`803`	`}`
`804`	`804`
`805`	`805`	`static void notify_cb(struct bt_conn conn, void data)`