drivers: display: features for ILI9341 driver

NickIOT72 · NickIOT72 · commit ff6820f0d913 · 2025-11-14T17:20:54.000-04:00
Replaced display-controller.yaml with lcd-controller.yaml
Deleted pixel format property, replacing it with the
property on lcd-controller.yaml. Replace ILI9XXX RGB macro
with PANEL RGB macro. Also, added condition to verify pixel
format is RGB565, BRG565 or RGB888, otherwise it will show error
Replaced &lt;zephyr/dt-bindings/display/ili9xxx.h&gt; with
&lt;zephyr/dt-bindings/display/panel.h&gt; and
ILI9XXX_PIXEL with PANEL_PIXEL in all Devicetrees
and files that contained both elements.
Added documentation for doc/releases/migration-guide-4.4.rst
in reference with the changes on the ili9xxx driver. Fixed some
script sintax

Signed-off-by: Nicolas Moreno &lt;niko722795@gmail.com&gt;
diff --git a/boards/m5stack/m5stack_core2/m5stack_core2_procpu.dts b/boards/m5stack/m5stack_core2/m5stack_core2_procpu.dts
@@ -9,7 +9,7 @@
 #include "m5stack_core2-pinctrl.dtsi"
 #include "grove_connectors.dtsi"
 #include "m5stack_mbus_connectors.dtsi"
-#include <zephyr/dt-bindings/display/ili9xxx.h>
+#include <zephyr/dt-bindings/display/panel.h>
 #include <zephyr/dt-bindings/regulator/axp192.h>
 #include <espressif/partitions_0x1000_amp.dtsi>
 
@@ -68,7 +68,7 @@
 			mipi-max-frequency = <30000000>;
 			reg = <0>;
 			vin-supply = <&lcd_bg>;
-			pixel-format = <ILI9XXX_PIXEL_FORMAT_RGB565>;
+			pixel-format = <PANEL_PIXEL_FORMAT_RGB565>;
 			display-inversion;
 			width = <320>;
 			height = <240>;
diff --git a/boards/m5stack/m5stack_cores3/m5stack_cores3_procpu_common.dtsi b/boards/m5stack/m5stack_cores3/m5stack_cores3_procpu_common.dtsi
@@ -6,7 +6,7 @@
 
 #include <espressif/esp32s3/esp32s3_wroom_n16r8.dtsi>
 #include <espressif/partitions_0x0_amp.dtsi>
-#include <zephyr/dt-bindings/display/ili9xxx.h>
+#include <zephyr/dt-bindings/display/panel.h>
 #include "m5stack_cores3-pinctrl.dtsi"
 #include "m5stack_mbus_connectors.dtsi"
 #include "grove_connectors.dtsi"
@@ -56,7 +56,7 @@
 			mipi-max-frequency = <30000000>;
 			reg = <0>;
 			vin-supply = <&vcc_bl>;
-			pixel-format = <ILI9XXX_PIXEL_FORMAT_RGB565>;
+			pixel-format = <PANEL_PIXEL_FORMAT_RGB565>;
 			display-inversion;
 			width = <320>;
 			height = <240>;
diff --git a/boards/m5stack/m5stack_fire/m5stack_fire_procpu.dts b/boards/m5stack/m5stack_fire/m5stack_fire_procpu.dts
@@ -10,7 +10,7 @@
 #include "m5stack_fire-pinctrl.dtsi"
 #include "grove_connectors.dtsi"
 #include "m5stack_mbus_connectors.dtsi"
-#include <zephyr/dt-bindings/display/ili9xxx.h>
+#include <zephyr/dt-bindings/display/panel.h>
 #include <espressif/partitions_0x1000_amp.dtsi>
 #include <zephyr/dt-bindings/input/input-event-codes.h>
 
@@ -95,7 +95,7 @@
 			compatible = "ilitek,ili9342c";
 			mipi-max-frequency = <30000000>;
 			reg = <0>;
-			pixel-format = <ILI9XXX_PIXEL_FORMAT_RGB565>;
+			pixel-format = <PANEL_PIXEL_FORMAT_RGB565>;
 			display-inversion;
 			width = <320>;
 			height = <240>;
diff --git a/boards/renesas/da14695_dk_usb/dts/da14695_dk_usb_mipi_dbi.overlay b/boards/renesas/da14695_dk_usb/dts/da14695_dk_usb_mipi_dbi.overlay
@@ -4,7 +4,7 @@
  * SPDX-License-Identifier: Apache-2.0
  */
 
-#include <zephyr/dt-bindings/display/ili9xxx.h>
+#include <zephyr/dt-bindings/display/panel.h>
 #include <zephyr/dt-bindings/gpio/gpio.h>
 
 / {
@@ -52,7 +52,7 @@
 		reg = <0>;
 		width = <240>;
 		height = <320>;
-		pixel-format = <ILI9XXX_PIXEL_FORMAT_RGB565>;
+		pixel-format = <PANEL_PIXEL_FORMAT_RGB565>;
 		rotation = <0>;
 	};
 };
diff --git a/boards/renesas/da1469x_dk_pro/dts/da1469x_dk_pro_mipi_dbi.overlay b/boards/renesas/da1469x_dk_pro/dts/da1469x_dk_pro_mipi_dbi.overlay
@@ -4,7 +4,7 @@
  * SPDX-License-Identifier: Apache-2.0
  */
 
-#include <zephyr/dt-bindings/display/ili9xxx.h>
+#include <zephyr/dt-bindings/display/panel.h>
 #include <zephyr/dt-bindings/gpio/gpio.h>
 
 / {
@@ -52,7 +52,7 @@
 		reg = <0>;
 		width = <240>;
 		height = <320>;
-		pixel-format = <ILI9XXX_PIXEL_FORMAT_RGB565>;
+		pixel-format = <PANEL_PIXEL_FORMAT_RGB565>;
 		rotation = <0>;
 	};
 };
diff --git a/boards/seeed/wio_terminal/wio_terminal.dts b/boards/seeed/wio_terminal/wio_terminal.dts
@@ -8,7 +8,7 @@
 #include "wio_terminal-pinctrl.dtsi"
 #include "grove_connectors.dtsi"
 #include "raspberrypi_40pins_connector.dtsi"
-#include <zephyr/dt-bindings/display/ili9xxx.h>
+#include <zephyr/dt-bindings/display/panel.h>
 #include <zephyr/dt-bindings/input/input-event-codes.h>
 
 / {
@@ -148,7 +148,7 @@
 			compatible = "ilitek,ili9341";
 			mipi-max-frequency = <24000000>;
 			reg = <0>;
-			pixel-format = <ILI9XXX_PIXEL_FORMAT_RGB565>;
+			pixel-format = <PANEL_PIXEL_FORMAT_RGB565>;
 			rotation = <270>;
 			width = <320>;
 			height = <240>;
diff --git a/boards/shields/adafruit_2_8_tft_touch_v2/boards/rd_rw612_bga.overlay b/boards/shields/adafruit_2_8_tft_touch_v2/boards/rd_rw612_bga.overlay
@@ -5,6 +5,7 @@
  */
 
 #include <zephyr/dt-bindings/spi/spi.h>
+#include <zephyr/dt-bindings/display/panel.h>
 
 / {
 	chosen {
@@ -44,7 +45,7 @@
 		reg = <0>;
 		width = <320>;
 		height = <240>;
-		pixel-format = <ILI9XXX_PIXEL_FORMAT_RGB888>;
+		pixel-format = <PANEL_PIXEL_FORMAT_RGB888>;
 		rotation = <90>;
 		frmctr1 = [00 18];
 		pwctrl1 = [23 00];
diff --git a/boards/shields/adafruit_2_8_tft_touch_v2/dts/adafruit_2_8_tft_touch_v2.dtsi b/boards/shields/adafruit_2_8_tft_touch_v2/dts/adafruit_2_8_tft_touch_v2.dtsi
@@ -4,7 +4,7 @@
  * SPDX-License-Identifier: Apache-2.0
  */
 
-#include <zephyr/dt-bindings/display/ili9xxx.h>
+#include <zephyr/dt-bindings/display/panel.h>
 #include <zephyr/dt-bindings/gpio/arduino-header-r3.h>
 
 / {
@@ -35,7 +35,7 @@
 			reg = <0>;
 			width = <320>;
 			height = <240>;
-			pixel-format = <ILI9XXX_PIXEL_FORMAT_RGB888>;
+			pixel-format = <PANEL_PIXEL_FORMAT_RGB888>;
 			rotation = <90>;
 			frmctr1 = [00 18];
 			pwctrl1 = [23 00];
diff --git a/boards/shields/buydisplay_2_8_tft_touch_arduino/buydisplay_2_8_tft_touch_arduino.overlay b/boards/shields/buydisplay_2_8_tft_touch_arduino/buydisplay_2_8_tft_touch_arduino.overlay
@@ -4,7 +4,7 @@
  * SPDX-License-Identifier: Apache-2.0
  */
 
-#include <zephyr/dt-bindings/display/ili9xxx.h>
+#include <zephyr/dt-bindings/display/panel.h>
 #include <zephyr/dt-bindings/gpio/arduino-header-r3.h>
 
 / {
@@ -36,7 +36,7 @@
 			reg = <0>;
 			width = <240>;
 			height = <320>;
-			pixel-format = <ILI9XXX_PIXEL_FORMAT_RGB565>;
+			pixel-format = <PANEL_PIXEL_FORMAT_RGB565>;
 			rotation = <0>;
 			frmctr1 = [00 18];
 			pwctrl1 = [23 00];
diff --git a/boards/shields/buydisplay_3_5_tft_touch_arduino/buydisplay_3_5_tft_touch_arduino.overlay b/boards/shields/buydisplay_3_5_tft_touch_arduino/buydisplay_3_5_tft_touch_arduino.overlay
@@ -4,7 +4,7 @@
  * SPDX-License-Identifier: Apache-2.0
  */
 
-#include <zephyr/dt-bindings/display/ili9xxx.h>
+#include <zephyr/dt-bindings/display/panel.h>
 #include <zephyr/dt-bindings/gpio/arduino-header-r3.h>
 
 / {
@@ -34,7 +34,7 @@
 			compatible = "ilitek,ili9488";
 			mipi-max-frequency = <25000000>;
 			reg = <0>;
-			pixel-format = <ILI9XXX_PIXEL_FORMAT_RGB888>;
+			pixel-format = <PANEL_PIXEL_FORMAT_RGB888>;
 			width = <320>;
 			height = <480>;
 			rotation = <0>;
diff --git a/boards/shields/x_nucleo_gfx01m2/x_nucleo_gfx01m2.overlay b/boards/shields/x_nucleo_gfx01m2/x_nucleo_gfx01m2.overlay
@@ -4,7 +4,7 @@
  * SPDX-License-Identifier: Apache-2.0
  */
 
-#include <zephyr/dt-bindings/display/ili9xxx.h>
+#include <zephyr/dt-bindings/display/panel.h>
 #include <zephyr/dt-bindings/mipi_dbi/mipi_dbi.h>
 #include <freq.h>
 #include <mem.h>
@@ -74,7 +74,7 @@
 			width = <240>;
 			height = <320>;
 			rotation = <180>;
-			pixel-format = <ILI9XXX_PIXEL_FORMAT_RGB565>;
+			pixel-format = <PANEL_PIXEL_FORMAT_RGB565>;
 			frmctr1 = [00 1f]; /* 60Hz frame rate */
 		};
 	};
diff --git a/boards/st/st25dv_mb1283_disco/st25dv_mb1283_disco.dts b/boards/st/st25dv_mb1283_disco/st25dv_mb1283_disco.dts
@@ -8,7 +8,7 @@
 #include "st/f4/stm32f405Xg.dtsi"
 #include "st/f4/stm32f405vgtx-pinctrl.dtsi"
 #include <zephyr/dt-bindings/input/input-event-codes.h>
-#include <zephyr/dt-bindings/display/ili9xxx.h>
+#include <zephyr/dt-bindings/display/panel.h>
 
 / {
 	model = "ST ST25DV Discovery Kit with MB1283";
@@ -86,7 +86,7 @@
 			compatible = "ilitek,ili9341";
 			mipi-max-frequency = <DT_FREQ_M(20)>;
 			reg = <0>;
-			pixel-format = <ILI9XXX_PIXEL_FORMAT_RGB888>;
+			pixel-format = <PANEL_PIXEL_FORMAT_RGB888>;
 			rotation = <0>;
 			width = <240>;
 			height = <320>;
diff --git a/boards/st/stm32f429i_disc1/stm32f429i_disc1.dts b/boards/st/stm32f429i_disc1/stm32f429i_disc1.dts
@@ -8,7 +8,7 @@
 /dts-v1/;
 #include <st/f4/stm32f429Xi.dtsi>
 #include <st/f4/stm32f429zitx-pinctrl.dtsi>
-#include <zephyr/dt-bindings/display/ili9xxx.h>
+#include <zephyr/dt-bindings/display/panel.h>
 #include <zephyr/dt-bindings/input/input-event-codes.h>
 
 / {
@@ -81,7 +81,7 @@
 			width = <240>;
 			height = <320>;
 			rotation = <180>;
-			pixel-format = <ILI9XXX_PIXEL_FORMAT_RGB565>;
+			pixel-format = <PANEL_PIXEL_FORMAT_RGB565>;
 			pwctrla = [39 2c 00 34 02];
 			pwctrlb = [00 c1 30];
 			timctrla = [85 00 78];
diff --git a/doc/releases/migration-guide-4.4.rst b/doc/releases/migration-guide-4.4.rst
@@ -32,6 +32,22 @@ Boards
 Device Drivers and Devicetree
 *****************************
 
+Display
+=======
+
+* The ILI9XXX display driver now supports ``CMD_SET_2`` for the ILI9341 ``madctl`` register
+  and use a conditional to set the ``ILI9XXX_MADCTL_BGR`` flag only when BGR format is specified,
+  resolving issues with display orientation and color representation respectively.
+  (see :github:`99267` for more information).
+* Enhanced mapping of RGB565, BGR565 and RGB888 pixel formats in the ILI9XXX display driver.
+  The device tree property ``panel-format`` now correctly maps to the corresponding
+  format stablished on the file ``include/zephyr/dt-bindings/display/panel.h``. and return
+  an error if an unsupported format is specified
+  (:github:`99267`).
+* Overlays and examples using the ILI9XXX display driver have been updated to reflect
+  the changes in pixel format mapping and to ensure correct display orientation and color representation.
+  (:github:`99267`).
+
 QSPI
 ===
 
diff --git a/drivers/display/display_ili9xxx.c b/drivers/display/display_ili9xxx.c
@@ -7,8 +7,7 @@
  */
 
 #include "display_ili9xxx.h"
-
-#include <zephyr/dt-bindings/display/ili9xxx.h>
+#include <zephyr/dt-bindings/display/panel.h>
 #include <zephyr/drivers/display.h>
 #include <zephyr/sys/byteorder.h>
 
@@ -324,7 +323,7 @@ static int ili9xxx_set_orientation(const struct device *dev,
 	struct ili9xxx_data *data = dev->data;
 
 	int r;
-	uint8_t tx_data = config->pixel_format == PIXEL_FORMAT_BGR_565
+	uint8_t tx_data = data->pixel_format == PIXEL_FORMAT_BGR_565
 			? ILI9XXX_MADCTL_BGR : 0;
 	if (config->quirks->cmd_set == CMD_SET_1) {
 		if (orientation == DISPLAY_ORIENTATION_NORMAL) {
@@ -393,12 +392,15 @@ static int ili9xxx_configure(const struct device *dev)
 	enum display_orientation orientation;
 
 	/* pixel format */
-	if (config->pixel_format == ILI9XXX_PIXEL_FORMAT_RGB565) {
+	if (config->pixel_format == PANEL_PIXEL_FORMAT_RGB_565) {
 		pixel_format = PIXEL_FORMAT_RGB_565;
-	} else if (config->pixel_format == ILI9XXX_PIXEL_FORMAT_BGR565) {
+	} else if (config->pixel_format == PANEL_PIXEL_FORMAT_BGR_565) {
 		pixel_format = PIXEL_FORMAT_BGR_565;
-	} else {
+	} else if (config->pixel_format == PANEL_PIXEL_FORMAT_RGB_888) {
 		pixel_format = PIXEL_FORMAT_RGB_888;
+	} else {
+		LOG_ERR("Unsupported pixel format in DT");
+		return -ENOTSUP;
 	}
 
 	r = ili9xxx_set_pixel_format(dev, pixel_format);
diff --git a/dts/bindings/display/ilitek,ili9xxx-common.yaml b/dts/bindings/display/ilitek,ili9xxx-common.yaml
@@ -8,24 +8,12 @@ description: |
     Ilitek ILI9XXX is a color TFT-LCD controller series.
 
 include:
-  - display-controller.yaml
+  - lcd-controller.yaml
   - name: mipi-dbi-spi-device.yaml
     property-blocklist:
       - te-delay
 
 properties:
-  pixel-format:
-    type: int
-    default: 0
-    enum:
-      - 0 # RGB565
-      - 1 # RGB888
-      - 2 # BGR565
-    description:
-      Display pixel format. Note that when RGB888 pixel format is selected
-      only 6 color bits are actually used being in practice equivalent to
-      RGB666.
-
   rotation:
     type: int
     default: 0
diff --git a/include/zephyr/dt-bindings/display/ili9xxx.h b/include/zephyr/dt-bindings/display/ili9xxx.h
@@ -9,6 +9,5 @@
 /* Pixel formats */
 #define ILI9XXX_PIXEL_FORMAT_RGB565 0U
 #define ILI9XXX_PIXEL_FORMAT_RGB888 1U
-#define ILI9XXX_PIXEL_FORMAT_BGR565 2U
 
 #endif /* ZEPHYR_INCLUDE_DT_BINDINGS_DISPLAY_ILI9XXX_H_ */
diff --git a/tests/drivers/display/display_read_write/adafruit_2_8_tft_touch_rgb565.overlay b/tests/drivers/display/display_read_write/adafruit_2_8_tft_touch_rgb565.overlay
@@ -4,10 +4,10 @@
  * SPDX-License-Identifier: Apache-2.0
  */
 
-#include <zephyr/dt-bindings/display/ili9xxx.h>
+#include <zephyr/dt-bindings/display/panel.h>
 
 &adafruit_2_8_tft_touch_v2_ili9340 {
-	pixel-format = <ILI9XXX_PIXEL_FORMAT_RGB565>;
+	pixel-format = <PANEL_PIXEL_FORMAT_RGB565>;
 };
 
 &adafruit_2_8_tft_touch_v2_mipi_dbi {
