'active_scan' parameter has no effect on the function behaviour

[ahmedmoheb-nordic]

Looking at this function

zephyr/subsys/bluetooth/host/id.c

Line 1527 in e027f06

int bt_id_set_scan_own_addr(bool active_scan, uint8_t *own_addr_type)

'active_scan' parameter is used once in a logical OR operation with a true condition, as !is_adv_using_rand_addr() should have been evaluated to true at line 1550

Also that makes the following debug message unreachable

zephyr/subsys/bluetooth/host/id.c

Line 1557 in e027f06

BT_WARN("Ignoring failure to set address for passive scan (%d)",

[ahmedmoheb-nordic]

@alwa-nordic @jori-nordic could you check this?

[alwa-nordic]

I'm not sure about this. This seems to be intentional. According to the commit message, the state of the advertiser can change between the two tests.

f332d51

commit f332d51d60c3e2603fab5ea82b148df3a809ac5a
Author: Joakim Andersson <[email protected]>
Date:   Tue Sep 15 12:47:58 2020 +0200

    Bluetooth: host: Ignore failure to set passive scanner address
    
    Ignore error when failing to set the passive scanner private address.
    This can happen because in between the time we checked if the
    advertiser was enabled and the time we execute the set random address
    command the state of the advertiser could have changed in the
    controller, and we only set the state once the command has completed
    in the controller.
    
    Fixes: #25672