Porting a driver of ST7735S, but getting error in generated file

[HonestQiao]

My system:
Ubuntu23.04
Zephyr 3.5.99
zephyr-sdk-0.16.3

I can compile sample with ST7735R:
west build -b nrf5340dk_nrf5340_cpuapp samples/subsys/display/lvgl -- -DSHIELD=st7735r_ada_160x128

I tried to port the driver for st7735s from st7735r.
All the files I have processed：HonestQiao/st7735s_driver_for_zephyr (github.com)

But I got an error when compiling:
west build -b nrf5340dk_nrf5340_cpuapp samples/subsys/display/lvgl -- -DSHIELD=st7735s_128x160

/home/honestqiao/zephyrproject/zephyr/drivers/display/display_st7735s.c: At top level:
/home/honestqiao/zephyrproject/zephyr/build/zephyr/include/generated/devicetree_generated.h:15794:54: error: expected declaration specifiers or '...' before numeric constant
15794 | #define DT_FOREACH_OKAY_INST_sitronix_st7735s(fn) fn(0)
      |                                                      ^
/home/honestqiao/zephyrproject/zephyr/include/zephyr/sys/util_internal.h:72:26: note: in definition of macro '__DEBRACKET'
   72 | #define __DEBRACKET(...) __VA_ARGS__
      |                          ^~~~~~~~~~~
/home/honestqiao/zephyrproject/zephyr/include/zephyr/sys/util_internal.h:64:9: note: in expansion of macro '__GET_ARG2_DEBRACKET'
   64 |         __GET_ARG2_DEBRACKET(one_or_two_args _if_code, _else_code)
      |         ^~~~~~~~~~~~~~~~~~~~
/home/honestqiao/zephyrproject/zephyr/include/zephyr/sys/util_internal.h:59:9: note: in expansion of macro '__COND_CODE'
   59 |         __COND_CODE(_XXXX##_flag, _if_1_code, _else_code)
      |         ^~~~~~~~~~~
/home/honestqiao/zephyrproject/zephyr/include/zephyr/sys/util_macro.h:180:9: note: in expansion of macro 'Z_COND_CODE_1'
  180 |         Z_COND_CODE_1(_flag, _if_1_code, _else_code)
      |         ^~~~~~~~~~~~~
/home/honestqiao/zephyrproject/zephyr/include/zephyr/devicetree.h:4151:9: note: in expansion of macro 'COND_CODE_1'
 4151 |         COND_CODE_1(DT_HAS_COMPAT_STATUS_OKAY(DT_DRV_COMPAT),   \
      |         ^~~~~~~~~~~
/home/honestqiao/zephyrproject/zephyr/include/zephyr/sys/util_internal.h:105:36: note: in expansion of macro 'DT_FOREACH_OKAY_INST_sitronix_st7735s'
  105 | #define UTIL_PRIMITIVE_CAT(a, ...) a##__VA_ARGS__
      |                                    ^
/home/honestqiao/zephyrproject/zephyr/include/zephyr/sys/util_internal.h:104:26: note: in expansion of macro 'UTIL_PRIMITIVE_CAT'
  104 | #define UTIL_CAT(a, ...) UTIL_PRIMITIVE_CAT(a, __VA_ARGS__)
      |                          ^~~~~~~~~~~~~~~~~~
/home/honestqiao/zephyrproject/zephyr/include/zephyr/devicetree.h:4152:22: note: in expansion of macro 'UTIL_CAT'
 4152 |                     (UTIL_CAT(DT_FOREACH_OKAY_INST_,            \
      |                      ^~~~~~~~
/home/honestqiao/zephyrproject/zephyr/drivers/display/display_st7735s.c:577:1: note: in expansion of macro 'DT_INST_FOREACH_STATUS_OKAY'
  577 | DT_INST_FOREACH_STATUS_OKAY(ST773S_INIT);
      | ^~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/honestqiao/zephyrproject/zephyr/drivers/display/display_st7735s.c:522:40: warning: 'st7735s_api' defined but not used [-Wunused-const-variable=]
  522 | static const struct display_driver_api st7735s_api = {
      |                                        ^~~~~~~~~~~
/home/honestqiao/zephyrproject/zephyr/drivers/display/display_st7735s.c:439:12: warning: 'st7735s_init' defined but not used [-Wunused-function]
  439 | static int st7735s_init(const struct device *dev)
      |            ^~~~~~~~~~~~
ninja: build stopped: subcommand failed.
FATAL ERROR: command exited with status 1: /usr/bin/cmake --build /home/honestqiao/zephyrproject/zephyr/build

Can someone help me determine the problem?
Thank you in advance for your response.

[mrrosen]

Looks like the Marco you copied but forgot to change to S instead of R:

#define ST7735R_INIT(inst)                                                        

If the two variants are similar enough, you might want to rename the existing driver st7735x and just handle the differences.

[HonestQiao]

It was my carelessness. Thank you for pointing out this problem!