External SPI Flash using STM32h7b0 / ospi-nor-flash / mt25ql256

[timwoolliscroft-opteran]

Hi, Not sure if I have a configuration issue or a bug. I have a working external QSpi flash other than erase.

My custom board is based on STM32h7b0 and has a mt25ql256 connected in quad mode, I also have the ability to erase the flash externally (its connected through a SPI bus mux and shared with a FPGA). My dts looks like this:

&octospi1 {
	pinctrl-0 = <&octospim_p1_clk_pb2 &octospim_p1_ncs_pb10
		     &octospim_p1_io0_pb1 &octospim_p1_io1_pb0
		     &octospim_p1_io2_pa7 &octospim_p1_io3_pa6>;
	pinctrl-names = "default";

	status = "okay";

	mx25ql256: ospi-nor-flash@70000000 {
		compatible = "st,stm32-ospi-nor";
		reg = <0x70000000 DT_SIZE_M(32)>; /* 256 Mbits*/
		ospi-max-frequency = <DT_FREQ_M(50)>;
		spi-bus-width = <OSPI_QUAD_MODE>;
		data-rate = <OSPI_STR_TRANSFER>;
		status = "okay";

		partitions {
			   compatible = "fixed-partitions";
			   #address-cells = <1>;
			   #size-cells = <1>;

			   partition@0 {
			       label = "nor";
			       reg = <0x00000000 DT_SIZE_M(4)>;
			   };
		};
	};
};

For my test application I am using:
CONFIG_FLASH_SHELL=y and have CONFIG_FLASH_LOG_LEVEL_DBG=y

My boot output looks like this:

[00:00:05.055,000] <dbg> flash_stm32h7: stm32h7_flash_init: Flash initialized. BS: 16
[00:00:05.055,000] <dbg> flash_stm32h7: stm32h7_flash_init: Block 0: bs: 8192 count: 16
[00:00:05.055,000] <dbg> flash_stm32h7: flash_stm32h7_write_protection: Disable write protection
[00:00:05.055,000] <dbg> flash_stm32_ospi: flash_stm32_ospi_init: OSPI Init'd
[00:00:05.155,000] <dbg> flash_stm32_ospi: flash_stm32_ospi_init: Reset Mem (SPI/STR)
[00:00:05.155,000] <dbg> flash_stm32_ospi: HAL_OSPI_StatusMatchCallback: Status Match cb
[00:00:05.155,000] <dbg> flash_stm32_ospi: flash_stm32_ospi_init: Mem Ready (SPI/STR)
[00:00:05.155,000] <inf> flash_stm32_ospi: OSPI flash config is SPI|DUAL|QUAD / STR
[00:00:05.155,000] <inf> flash_stm32_ospi: Read SFDP from octoFlash
[00:00:05.155,000] <dbg> flash_stm32_ospi: flash_stm32_ospi_init: ospi-nor-flash@70000000: SFDP v 1.6 AP ff with 2 PH
[00:00:05.155,000] <dbg> flash_stm32_ospi: flash_stm32_ospi_init: PH0: ff00 rev 1.6: 16 DW @ 30
[00:00:05.155,000] <inf> flash_stm32_ospi: Read SFDP from octoFlash
[00:00:05.155,000] <dbg> flash_stm32_ospi: spi_nor_process_bfp: ospi-nor-flash@70000000: 32 MiBy flash
[00:00:05.155,000] <dbg> flash_stm32_ospi: spi_nor_process_bfp: Erase 4096 with 20
[00:00:05.155,000] <dbg> flash_stm32_ospi: spi_nor_process_bfp: Erase 65536 with d8
[00:00:05.155,000] <dbg> flash_stm32_ospi: spi_nor_process_bfp: Erase 32768 with 52
[00:00:05.155,000] <dbg> flash_stm32_ospi: spi_nor_process_bfp: Address width: 4 Bytes
[00:00:05.155,000] <dbg> flash_stm32_ospi: spi_nor_process_bfp: Supports read mode: 3, instr: 0x3B
[00:00:05.155,000] <dbg> flash_stm32_ospi: spi_nor_process_bfp: Supports read mode: 6, instr: 0xBB
[00:00:05.155,000] <dbg> flash_stm32_ospi: spi_nor_process_bfp: Supports read mode: 4, instr: 0x6B
[00:00:05.155,000] <dbg> flash_stm32_ospi: spi_nor_process_bfp: Supports read mode: 7, instr: 0xEB
[00:00:05.155,000] <dbg> flash_stm32_ospi: spi_nor_process_bfp: QE requirement mode: 0
[00:00:05.155,000] <dbg> flash_stm32_ospi: spi_nor_process_bfp: QUAD mode enabled
[00:00:05.155,000] <dbg> flash_stm32_ospi: spi_nor_process_bfp: Page size 256 bytes
[00:00:05.155,000] <dbg> flash_stm32_ospi: spi_nor_process_bfp: Flash size 33554432 bytes
[00:00:05.155,000] <dbg> flash_stm32_ospi: spi_nor_process_bfp: Using read mode: 7, instr: 0xEB, dummy cycles: 10
[00:00:05.155,000] <dbg> flash_stm32_ospi: spi_nor_process_bfp: Using write instr: 0x38
[00:00:05.155,000] <dbg> flash_stm32_ospi: flash_stm32_ospi_init: PH1: ff84 rev 1.0: 2 DW @ 80
[00:00:05.155,000] <inf> flash_stm32_ospi: Read SFDP from octoFlash
[00:00:05.155,000] <dbg> flash_stm32_ospi: setup_pages_layout: layout page 256 not compatible with erase size 4096
[00:00:05.155,000] <dbg> flash_stm32_ospi: setup_pages_layout: erase size will be used as layout page size
[00:00:05.155,000] <dbg> flash_stm32_ospi: setup_pages_layout: layout 8192 x 4096 By pages
[00:00:05.155,000] <inf> flash_stm32_ospi: NOR octo-flash at 0x70000000 (0x2000000 bytes)

So far so good!

I test the read:

uart:~$ flash read ospi-nor-flash@70000000 0x20000 0x10
00020000: ff ff ff ff ff ff ff ff  ff ff ff ff ff ff ff ff |........ ........|

[00:02:58.156,000] <inf> ova_app_main: Main test IMU callback temp (33.2)
[00:02:58.478,000] <dbg> flash_stm32_ospi: flash_stm32_ospi_read: OSPI: read 16 data
[00:02:58.478,000] <dbg> flash_stm32_ospi: ospi_read_access: Instruction 0xeb
[00:02:58.478,000] <dbg> flash_stm32_ospi: HAL_OSPI_RxCpltCallback: Rx Cplt cb

Blank - still good

Test the write:

uart:~$ flash write ospi-nor-flash@70000000 0x20000 0x12345678
Write OK.
Verified.
[00:06:04.121,000] <dbg> flash_stm32_ospi: flash_stm32_ospi_write: OSPI: write 4 data
[00:06:04.121,000] <dbg> flash_stm32_ospi: HAL_OSPI_StatusMatchCallback: Status Match cb
[00:06:04.121,000] <dbg> flash_stm32_ospi: HAL_OSPI_StatusMatchCallback: Status Match cb
[00:06:04.121,000] <dbg> flash_stm32_ospi: ospi_write_access: Instruction 0x38
[00:06:04.121,000] <dbg> flash_stm32_ospi: HAL_OSPI_TxCpltCallback: Tx Cplt cb
[00:06:04.121,000] <dbg> flash_stm32_ospi: HAL_OSPI_StatusMatchCallback: Status Match cb
[00:06:04.122,000] <dbg> flash_stm32_ospi: flash_stm32_ospi_read: OSPI: read 4 data
[00:06:04.122,000] <dbg> flash_stm32_ospi: ospi_read_access: Instruction 0xeb
[00:06:04.122,000] <dbg> flash_stm32_ospi: HAL_OSPI_RxCpltCallback: Rx Cplt cb


uart:~$ flash read ospi-nor-flash@70000000 0x20000 0x10
00020000: 78 56 34 12 ff ff ff ff  ff ff ff ff ff ff ff ff |xV4..... ........|

[00:06:58.703,000] <dbg> flash_stm32_ospi: flash_stm32_ospi_read: OSPI: read 16 data
[00:06:58.703,000] <dbg> flash_stm32_ospi: ospi_read_access: Instruction 0xeb
[00:06:58.703,000] <dbg> flash_stm32_ospi: HAL_OSPI_RxCpltCallback: Rx Cplt cb

Great! but...

uart:~$ flash erase ospi-nor-flash@70000000 0x20000 0x1000
Erase success.
[00:08:19.490,000] <dbg> flash_stm32_ospi: HAL_OSPI_StatusMatchCallback: Status Match cb
[00:08:19.490,000] <dbg> flash_stm32_ospi: HAL_OSPI_StatusMatchCallback: Status Match cb
[00:08:19.490,000] <dbg> flash_stm32_ospi: flash_stm32_ospi_erase: Sector/Block Erase
[00:08:19.490,000] <dbg> flash_stm32_ospi: flash_stm32_ospi_erase: Sector/Block Erase addr 0x2000, asize 0x3000 amode 0x100  instr 0x21
[00:08:19.490,000] <dbg> flash_stm32_ospi: ospi_send_cmd: Instruction 0x21
[00:08:19.490,000] <dbg> flash_stm32_ospi: ospi_send_cmd: CCR 0x3101
[00:08:19.494,000] <dbg> flash_stm32_ospi: HAL_OSPI_StatusMatchCallback: Status Match cb

uart:~$ flash read ospi-nor-flash@70000000 0x20000 0x10
00020000: 78 56 34 12 ff ff ff ff  ff ff ff ff ff ff ff ff |xV4..... ........|

[00:08:26.796,000] <dbg> flash_stm32_ospi: flash_stm32_ospi_read: OSPI: read 16 data
[00:08:26.796,000] <dbg> flash_stm32_ospi: ospi_read_access: Instruction 0xeb
[00:08:26.796,000] <dbg> flash_stm32_ospi: HAL_OSPI_RxCpltCallback: Rx Cplt cb

😢 - My erase didn't happen!

Looking at the datasheet, I don't think this device has a 0x21 erase instruction command?

Any advice / further debug pointers appreciated!!!!

[FRASTM]

Hello @timwoolliscroft-opteran

can you try with PR #70434

[timwoolliscroft-opteran]

Fixed it - Thankyou !!!

Was sure I'd checked existing bugs but didn't find this!

[FRASTM]

there is none, only a PR

[timwoolliscroft-opteran]

Sorry a bit more detail in the flash device data sheet - 0x21 is a valid 4KB subsector erase with a 4 byte address

Even more lost now.

[FRASTM]

right, and when in octo mode, 0x21DE "octal sector erase" is selected