Defining flexspi node in device tree but pin control (pinctrl) doesn't work.

[cypressApp]

Hi,

Hope you are all well.

I want to define a node for flexspi in imx8mp.

In nxp_imx8ml_m7.dtsi:

imx_flexspi: imx_flexspi@30BB0000 {
	compatible = "nxp,imx-flexspi";
	reg = <0x30BB0000 DT_SIZE_K(1)>;
	#address-cells = <1>;
	#size-cells = <0>;
	interrupts = <107 0>;
	status = "disabled";
};	

In imx8mp_evk_mimx8ml8_m7.dts:

&imx_flexspi {
	status = "okay";
	pinctrl-0 = <&imx_flexspi_default>;
	pinctrl-names = "default";
};

&pinctrl {

	ecspi2_default: ecspi2_default {

		group1 {
			pinmux = <&iomuxc_ecspi2_miso_ecspi_miso_ecspi2_miso>,
				 <&iomuxc_ecspi2_mosi_ecspi_mosi_ecspi2_mosi>,
				 <&iomuxc_ecspi2_sclk_ecspi_sclk_ecspi2_sclk>;
			slew-rate = "fast";
			drive-strength = "x6";
		};

		group2 {
			pinmux = <&iomuxc_ecspi2_ss0_ecspi_ss_ecspi2_ss0>;
			slew-rate = "fast";
			drive-strength = "x6";
			bias-pull-up;
		};		
		
	};
	
	imx_flexspi_default: imx_flexspi_default {
	
		group1 {
			pinmux = <&iomuxc_nand_ale_qspi_a_sclk_qspi_a_sclk>,
				 <&iomuxc_nand_ce0_b_qspi_a_ss0_b_qspi_a_ss0_b>,
				 <&iomuxc_nand_data00_qspi_a_data_qspi_a_data0>,
				 <&iomuxc_nand_data01_qspi_a_data_qspi_a_data1>,
				 <&iomuxc_nand_data02_qspi_a_data_qspi_a_data2>,
				 <&iomuxc_nand_data03_qspi_a_data_qspi_a_data3>;
			drive-strength = "x6";
			slew-rate = "fast";
		};
	
	};
	
};

In prj.conf:

CONFIG_PINCTRL=y

The code is compiled without issue. After loading the code on CM7 it booted and call the flexspi driver but it is expected to change the pinmux for flexspi pins to 1 but it is still 5.

root@imx8mp-lpddr4-evk:~# devmem2 0x303300FC
/dev/mem opened.
Memory mapped at address 0xffffa4c78000.
Read at address  0x303300FC (0xffffa4c780fc): 0x00000005

I can change the pinmux to 1 by memory mapping and it works fine. However, it doesn't work when I use pinctrl?

Thanks,
Majid.

[zczhou314]

With your changes, the flexspi is not configured in Kconfig system. So the compilation does not pull in flexspi driver. That is why the pin control does not take effect.

I added the followings to the end of boards/nxp/imx8mp_evk/Kconfig.defconfig
config MEMC
default y

config MEMC_MCUX_FLEXSPI
default y

Now it starts to compile flexspi related code, and compilation fails due to error.
Additional porting work is needed to get flexspi to work for imx8mp.

[cypressApp]

Thank you for your reply

I added it but I get this error:

In file included from /home/xxx/nxp/Repositories/ZephyrOs2/zephyr/modules/hal/nxp/mcux/mcux-sdk/drivers/flexspi/fsl_flexspi.c:9:
/home/xxx/nxp/Repositories/ZephyrOs2/zephyr/modules/hal/nxp/mcux/mcux-sdk/drivers/flexspi/fsl_flexspi.h:31:46: warning: implicit declaration of function 'FSL_FEATURE_FLEXSPI_AHB_BUFFER_COUNTn'; did you mean 'FSL_FEATURE_FLEXSPI_AHB_BUFFER_COUNT'? [-Wimplicit-function-declaration]
   31 | #define FSL_FEATURE_FLEXSPI_AHB_BUFFER_COUNT FSL_FEATURE_FLEXSPI_AHB_BUFFER_COUNTn(0)
      |                                              ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/xxx/nxp/Repositories/ZephyrOs2/zephyr/modules/hal/nxp/mcux/mcux-sdk/drivers/flexspi/fsl_flexspi.h:31:46: note: in definition of macro 'FSL_FEATURE_FLEXSPI_AHB_BUFFER_COUNT'
   31 | #define FSL_FEATURE_FLEXSPI_AHB_BUFFER_COUNT FSL_FEATURE_FLEXSPI_AHB_BUFFER_COUNTn(0)
      |                                              ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/xxx/nxp/Repositories/ZephyrOs2/zephyr/modules/hal/nxp/mcux/mcux-sdk/drivers/flexspi/fsl_flexspi.h:271:36: error: variably modified 'buffer' at file scope
  271 |         flexspi_ahbBuffer_config_t buffer[FSL_FEATURE_FLEXSPI_AHB_BUFFER_COUNT]; /*!< AHB buffer size. */
      |                                    ^~~~~~
/home/xxx/nxp/Repositories/ZephyrOs2/zephyr/modules/hal/nxp/mcux/mcux-sdk/drivers/flexspi/fsl_flexspi.c:94:42: error: 'FLEXSPI_IRQS' undeclared here (not in a function); did you mean 'FlexSPI_IRQn'?
   94 | static const IRQn_Type s_flexspiIrqs[] = FLEXSPI_IRQS;
      |                                          ^~~~~~~~~~~~
      |                                          FlexSPI_IRQn
/home/xxx/nxp/Repositories/ZephyrOs2/zephyr/modules/hal/nxp/mcux/mcux-sdk/drivers/flexspi/fsl_flexspi.c:98:49: error: 'FLEXSPI_CLOCKS' undeclared here (not in a function); did you mean 'ECSPI_CLOCKS'?
   98 | static const clock_ip_name_t s_flexspiClock[] = FLEXSPI_CLOCKS;
      |                                                 ^~~~~~~~~~~~~~
      |                                                 ECSPI_CLOCKS
ninja: build stopped: subcommand failed.
FATAL ERROR: command exited with status 1: /usr/bin/cmake --build /home/xxx/nxp/Repositories/ZephyrOs2/zephyr/build
cp: cannot stat 'build/zephyr/zephyr.elf': No such file or directory

I also clone the last version but I get the same error.

[zczhou314]

Yes. I got the same error. Additional porting work is needed to get flexspi to work for imx8mp.