Something is wrong when trying ST7789V sample

[zzzh]

Describe the bug
Hello,
I have a ST7789V based LCD module ( a 1.54" one, not TL019FQV01), and nrf52_pca10040 board, so I did a try on ST7789V sample.
Unfortunately, I got "display_st7789v: Could not get SPI device for LCD", I checked the code and realize that it can't find it from the inited driver.
I don't understand why, any ideas?

To Reproduce
Steps to reproduce the behavior:
Just follow the readme in ST7789V sample

Expected behavior
see something being showed on the LCD

Impact
annoyance

Screenshots or console output
***** Booting Zephyr OS build zephyr-v2.0.0-1112-gb71eb71de72f *****
[00:00:00.005,462] display_st7789v: Could not get SPI device for LCD
[00:00:00.005,462] app: ST7789V display sample
[00:00:00.005,493] app: Device not found. Aborting test.

Environment (please complete the following information):

• OS: Linux
• Toolchain: Zephyr SDK
• Commit SHA or Version used: 2.099

Additional context
nothing more by now

[vanwinkeljan]

@zzzh did you have any chance in testing my responce on your question in the orignal PR #17358 (comment) ?

[zzzh]

@vanwinkeljan Thanks for replying.
I did not try that, and don't think that's the way to solve it.
Actually, I'd fixed it by adding a line in proj.conf : CONFIG_SPI_x=y, x is the number of SPI channel you chose in the overlay file.
@carlescufi I think this is a bug.

[vanwinkeljan]

@zzzh

I did not try that, and don't think that's the way to solve it. Actually, I'd fixed it by adding a line in proj.conf : CONFIG_SPI_x=y, x is the number of SPI channel you chose in the overlay file.

Note that CONFIG_SPI_1 is set by default to y, so that is the reason why asked if you could use SPI 1 instead.

But anyway if it is solved by setting CONFIG_SPI_0=y than it confirms it is a bug.

[jfischer-no]

The sample self is a bug, I suggest to remove this sample from the tree and add a generic shield for arduino spi.

[vanwinkeljan]

@jfischer-phytec-iot I created a PR #20570 to introduce a ST7789V shield and updated the existing sample. I will create a seperate PR to introduce a common sample for display shields.

@zzzh could you verify if the sample is working with PR #20570, I do not have a ST7789V based display?

Example build command:
west build -b nrf52_pca10040 samples/display/st7789v -- -DSHIELD=st7789v_generic