compliance script broken

[pabigot]

After 251648a I'm getting the following on the master branch:

tirzah[31]$ scripts/ci/check_compliance.py -c HEAD^..HEAD
Running checkpatch       tests in /scratch/zephyr/zp1/zephyr ...
Running Kconfig          tests in /scratch/zephyr/zp1/zephyr ...
Python exception in `scripts/ci/check_compliance.py`:

Traceback (most recent call last):
  File "/scratch/zephyr/zp1/zephyr/scripts/kconfig/kconfiglib.py", line 2189, in _enter_file
    self._readline = self._open(filename, "r").readline
  File "/scratch/zephyr/zp1/zephyr/scripts/kconfig/kconfiglib.py", line 3922, in _open
    open(filename, mode, encoding=self._encoding)
IsADirectoryError: [Errno 21] Is a directory: '/scratch/zephyr/zp1/zephyr/'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "scripts/ci/check_compliance.py", line 1081, in main
    n_fails = _main(args)
  File "scripts/ci/check_compliance.py", line 1032, in _main
    test.run()
  File "scripts/ci/check_compliance.py", line 229, in run
    kconf = self.parse_kconfig()
  File "scripts/ci/check_compliance.py", line 335, in parse_kconfig
    return kconfiglib.Kconfig()
  File "/scratch/zephyr/zp1/zephyr/scripts/kconfig/kconfiglib.py", line 947, in __init__
    self._init(filename, warn, warn_to_stderr, encoding)
  File "/scratch/zephyr/zp1/zephyr/scripts/kconfig/kconfiglib.py", line 1085, in _init
    self._parse_block(None, self.top_node, self.top_node).next = None
  File "/scratch/zephyr/zp1/zephyr/scripts/kconfig/kconfiglib.py", line 2989, in _parse_block
    prev = self._parse_block(None, parent, prev)
  File "/scratch/zephyr/zp1/zephyr/scripts/kconfig/kconfiglib.py", line 3028, in _parse_block
    self._parse_block(_T_ENDMENU, node, node)
  File "/scratch/zephyr/zp1/zephyr/scripts/kconfig/kconfiglib.py", line 2989, in _parse_block
    prev = self._parse_block(None, parent, prev)
  File "/scratch/zephyr/zp1/zephyr/scripts/kconfig/kconfiglib.py", line 2989, in _parse_block
    prev = self._parse_block(None, parent, prev)
  File "/scratch/zephyr/zp1/zephyr/scripts/kconfig/kconfiglib.py", line 3028, in _parse_block
    self._parse_block(_T_ENDMENU, node, node)
  File "/scratch/zephyr/zp1/zephyr/scripts/kconfig/kconfiglib.py", line 2988, in _parse_block
    self._enter_file(filename)
  File "/scratch/zephyr/zp1/zephyr/scripts/kconfig/kconfiglib.py", line 2192, in _enter_file
    raise _KconfigIOError(
kconfiglib._KconfigIOError: /tmp/Kconfig.modules:2: Could not open '/scratch/zephyr/zp1/zephyr/' (in 'osource "$(ZEPHYR_HAL_NORDIC_KCONFIG)"') (EISDIR: Is a directory)

Traceback (most recent call last):
  File "/scratch/zephyr/zp1/zephyr/scripts/kconfig/kconfiglib.py", line 2189, in _enter_file
    self._readline = self._open(filename, "r").readline
  File "/scratch/zephyr/zp1/zephyr/scripts/kconfig/kconfiglib.py", line 3922, in _open
    open(filename, mode, encoding=self._encoding)
IsADirectoryError: [Errno 21] Is a directory: '/scratch/zephyr/zp1/zephyr/'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "scripts/ci/check_compliance.py", line 1108, in <module>
    main()
  File "scripts/ci/check_compliance.py", line 1081, in main
    n_fails = _main(args)
  File "scripts/ci/check_compliance.py", line 1032, in _main
    test.run()
  File "scripts/ci/check_compliance.py", line 229, in run
    kconf = self.parse_kconfig()
  File "scripts/ci/check_compliance.py", line 335, in parse_kconfig
    return kconfiglib.Kconfig()
  File "/scratch/zephyr/zp1/zephyr/scripts/kconfig/kconfiglib.py", line 947, in __init__
    self._init(filename, warn, warn_to_stderr, encoding)
  File "/scratch/zephyr/zp1/zephyr/scripts/kconfig/kconfiglib.py", line 1085, in _init
    self._parse_block(None, self.top_node, self.top_node).next = None
  File "/scratch/zephyr/zp1/zephyr/scripts/kconfig/kconfiglib.py", line 2989, in _parse_block
    prev = self._parse_block(None, parent, prev)
  File "/scratch/zephyr/zp1/zephyr/scripts/kconfig/kconfiglib.py", line 3028, in _parse_block
    self._parse_block(_T_ENDMENU, node, node)
  File "/scratch/zephyr/zp1/zephyr/scripts/kconfig/kconfiglib.py", line 2989, in _parse_block
    prev = self._parse_block(None, parent, prev)
  File "/scratch/zephyr/zp1/zephyr/scripts/kconfig/kconfiglib.py", line 2989, in _parse_block
    prev = self._parse_block(None, parent, prev)
  File "/scratch/zephyr/zp1/zephyr/scripts/kconfig/kconfiglib.py", line 3028, in _parse_block
    self._parse_block(_T_ENDMENU, node, node)
  File "/scratch/zephyr/zp1/zephyr/scripts/kconfig/kconfiglib.py", line 2988, in _parse_block
    self._enter_file(filename)
  File "/scratch/zephyr/zp1/zephyr/scripts/kconfig/kconfiglib.py", line 2192, in _enter_file
    raise _KconfigIOError(
kconfiglib._KconfigIOError: /tmp/Kconfig.modules:2: Could not open '/scratch/zephyr/zp1/zephyr/' (in 'osource "$(ZEPHYR_HAL_NORDIC_KCONFIG)"') (EISDIR: Is a directory)

[pabigot]

It appears that 6d3cdf5 inadvertently fixed this.

[pabigot]

No, I'm still seeing it.

[mbolivar-nordic]

I can reproduce.

[henrikbrixandersen]

I can reproduce the issue here.

$ lsb_release -a
No LSB modules are available.
Distributor ID:	Ubuntu
Description:	Ubuntu 18.04.5 LTS
Release:	18.04
Codename:	bionic

[pabigot]

A clean revert would probably require reverting:

• bt: ipc: Add ipc multiendpoint #31115 then
• modules: Move nrfx glue code to main Zephyr repository #31224
  which involves seven commits.

[pabigot]

In case it's OS dependent:

tirzah[2195]$ lsb_release -a
No LSB modules are available.
Distributor ID:	Ubuntu
Description:	Ubuntu 20.04.1 LTS
Release:	20.04
Codename:	focal

[pabigot]

Per comment on slack from @mbolivar-nordic this may be related to having ZEPHYR_BASE set.

[tejlmand]

Looking into a fix.

Somehow CI didn't fail the pr, even though compliance failed.
https://github.com/zephyrproject-rtos/zephyr/runs/1727523984#step:7:157