TFM: Nordic pinctrl consumers broken

[JordanYates]

Describe the bug

The TFM and Zephyr repositories have mismatched views on how the pinctrl uint32_t is constructed.

https://github.com/zephyrproject-rtos/trusted-firmware-m/blob/069455be098383bf96eab73e3ff8e0c66c60fa5a/platform/ext/target/nordic_nrf/common/core/common/nrf-pinctrl.h#L9-L20

zephyr/include/zephyr/dt-bindings/pinctrl/nrf-pinctrl.h

Lines 9 to 20 in cce7e9a

	/*
	* The whole nRF pin configuration information is encoded in a 32-bit bitfield
	* organized as follows:
	*
	* - 31..18: Pin function.
	* - 17: Clockpin enable.
	* - 16: Pin inversion mode.
	* - 15: Pin low power mode.
	* - 14..11: Pin output drive configuration.
	* - 10..9: Pin pull configuration.
	* - 8..0: Pin number (combination of port and pin).
	*/

The pinctrl values are consumed by the TFM USART driver:
https://github.com/zephyrproject-rtos/trusted-firmware-m/blob/069455be098383bf96eab73e3ff8e0c66c60fa5a/platform/ext/target/nordic_nrf/common/core/cmsis_drivers/Driver_USART.c#L56-L74

Introduced in:

• dt-bindings: pinctrl: nrf: allow for more ports #73097
• Rework how nordic,clock-enable works #76847

This was probably missed because NRF_FUN_UART_TX is 0, so the shift in bits doesn't affect this one pin.
The flow control and RX pins are currently broken.

The first PR is present in Zephyr v3.7.0, so the LTS driver does not currently work as expected.

Expected behavior

TFM and Zephyr need the same view on pinctrl, as TFM consumes the values created by the Zephyr build system.

Impact

Nordic TFM consumers of pinctrl are currently broken.

Environment (please complete the following information):

• Zephyr v3.7.0

[nordic-piks]

Triaged internally

[github-actions]

This issue has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this issue will automatically be closed in 14 days. Note, that you can always re-open a closed issue at any time.