Multiple ICE40 instances on the same SPI master

[benediktibk]

Describe the bug
When multiple ICE40 instances on the same SPI master are enabled the build will fail, as there will be multiple instances of the same pinctrl-config object within fpga_ice40.c.

To Reproduce

1. CONFIG_PINCTRL=y
2. enable two instances of lattice,ice40-fpga on the same master.
3. west build -> BOOM

Expected behavior
It should be possible to use two ICE40 with PINCTRL on the same SPI master.

[tbursztyka]

Could you give more detailed steps on how to reproduce? I miss the board and the sample/test to use.

[benediktibk]

Could you give more detailed steps on how to reproduce? I miss the board and the sample/test to use.

With the current setup the corresponding test doesn't trigger the issue, as there is a workaround for it in place. But if you set CONFIG_PINCTRL=y in zephyr/tests/drivers/build_all/fpga/prj.conf you can trigger the issue with west build --board nucleo_f746zg zephyr/tests/drivers/build_all/fpga.

[cfriedt]

This issue also came up when the ice40 driver was added. But at the time, there was no clean way to program multiple nodes on the same SPI bus, since it was not possible to reset to a default SPI pinctrl state.

Ultimately, the SPI API will likely need to be changed to fix this issue.

[github-actions]

This issue has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this issue will automatically be closed in 14 days. Note, that you can always re-open a closed issue at any time.

[benediktibk]

After #80854 has been merged the problem is reduced to the driver for lattice,ice40-fpga-bitbang. Therefore less severe, but still existing.