mbedtls: build error due to #include location in `modules/crypto/mbedtls/library/x509_crt.c`

[thenguyenyf]

Describe the bug

A build error occur on Github CI for Renesas RA family after this PR was merged #72804. It seems it is an issue of mbedtls module relevant to location to include the syscall header file, so this preprocessor causes a conflict to the IODefine in HAL external module

modules/crypto/mbedtls/library/x509_crt.c:1750

 #define BC              "18"

and drivers/ra/fsp/src/bsp/cmsis/Device/RENESAS/Include/R7FA8M1AH.h

union
    {
        __IOM uint8_t ICMR1;           /*!< (@ 0x00000002) I2C Bus Mode Register 1                                    */

        struct
        {
            __IOM uint8_t BC   : 3;    /*!< [2..0] Bit Counter                                                        */
            __OM uint8_t  BCWP : 1;    /*!< [3..3] BC Write Protect(This bit is read as 1.)                           */
            __IOM uint8_t CKS  : 3;    /*!< [6..4] Internal Reference Clock (fIIC) Selection ( fIIC = PCLKB
                                        *   / 2^CKS )                                                                 */
            __IOM uint8_t MTWP : 1;    /*!< [7..7] MST/TRS Write Protect                                              */
        } ICMR1_b;
    };

I can build okay without warning when I move these inclusions to the top of the file
library/x509_crt.c:2688

#ifdef _WIN32
#ifdef _MSC_VER
#pragma comment(lib, "ws2_32.lib")
#include <winsock2.h>
#include <ws2tcpip.h>
#elif (defined(__MINGW32__) || defined(__MINGW64__)) && _WIN32_WINNT >= 0x0600
#include <winsock2.h>
#include <ws2tcpip.h>
#else
/* inet_pton() is not supported, fallback to software version */
#define MBEDTLS_TEST_SW_INET_PTON
#endif
#elif defined(__sun)
/* Solaris requires -lsocket -lnsl for inet_pton() */
#elif defined(__has_include)
#if __has_include(<sys/socket.h>)
#include <sys/socket.h>
#endif
#if __has_include(<arpa/inet.h>)
#include <arpa/inet.h>
#endif
#endif

To Reproduce

Build this sample for any Renesas RA board (such as ek_ra8m1)

west build -p -b ek_ra8d1 samples/net/prometheus -T sample.net.prometheus

Expected behavior

No build warnings

Impact

It makes the Renesas RA boards cannot use the mbedtls with Socket or INET config is enabled. Btw, the Github workflow CI will be return fail for Twister build on this sample: samples/net/prometheus

Logs and console output

/__w/zephyr/modules/crypto/mbedtls/library/x509_crt.c:1750:25: error: expected identifier or '(' before string constant
 1750 | #define BC              "18"
      |                         ^~~~
/__w/zephyr/modules/hal/renesas/drivers/ra/fsp/src/bsp/cmsis/Device/RENESAS/Include/R7FA8D1BH.h:10594:27: note: in expansion of macro 'BC'
10594 |             __IOM uint8_t BC   : 3;    /*!< [2..0] Bit Counter                                                        */
      |                           ^~
ninja: build stopped: subcommand failed.

Environment (please complete the following information):

• OS: Linux
• Toolchain: ZephyrSDK 0.16.8
• Commit SHA or Version used: 98e0e65

[github-actions]

Hi @thenguyenyf! We appreciate you submitting your first issue for our open-source project. 🌟

Even though I'm a bot, I can assure you that the whole community is genuinely grateful for your time and effort. 🤖💙

[github-actions]

This issue has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this issue will automatically be closed in 14 days. Note, that you can always re-open a closed issue at any time.