Skip to content

stm32: usb: inconsistent clock selection, at least on U5 #95646

@bearsh

Description

@bearsh

Describe the bug

The usb peripheral consists of two part the controller and the phy. Looking at the U5, if has a "st,stm32-otghs" controller and a "st,stm32u5-otghs-phy" phy. both have a clocks property.

The current driver udc_stm32.c is able to use 2 arguments to the clocks property of the controller, the clocks property of the phy is ignore. this means, if someone want to use the PLL_p clock for usb, he needs to add e.g. <&rcc STM32_SRC_PLL1_P OTGHS_SEL(1)> the the clocks property of the controller. but to make it work with frequencies other than 16MHz, a clock-reference property has to be added to the phy.

this seems quite strange as part of the phy clocking is configured in the controller part in the phy node. furthermore, phy node's clock property is ignored.

Impact

Annoyance – Minor irritation; no significant impact on usability or functionality.

Environment

Metadata

Metadata

Labels

area: USBUniversal Serial BusbugThe issue is a bug, or the PR is fixing a bugplatform: STM32ST Micro STM32priority: lowLow impact/importance bug

Type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions