posix: Missing signal.h header file

[pdgendt]

Describe the bug

A regression introduced by 1eb5c97

Regression

• This is a regression.

Steps to reproduce

$ west build -p -b native_sim/native tests/net/wifi/configs -T wifi.build.hostapd_ap

Relevant log output

FAILED: zephyr/CMakeFiles/zephyr.dir/__w/zephyr/modules/lib/hostap/src/common/wpa_common.c.obj 
ccache /usr/bin/gcc -DCONFIG_AP -DCONFIG_CTRL_IFACE -DCONFIG_CTRL_IFACE_ZEPHYR -DCONFIG_ECC -DCONFIG_IEEE80211AC -DCONFIG_IEEE80211AX -DCONFIG_MBO -DCONFIG_NO_ACCOUNTING -DCONFIG_NO_CONFIG_WRITE -DCONFIG_NO_RADIUS -DCONFIG_NO_RANDOM_POOL -DCONFIG_NO_VLAN -DCONFIG_SAE -DCONFIG_SHA256 -DCONFIG_SHA384 -DCONFIG_SHA512 -DCONFIG_SME -DCONFIG_SUITEB -DCONFIG_SUITEB192 -DCONFIG_WEP -DCONFIG_WNM -DEAP_SERVER -DEAP_SERVER_IDENTITY -DKERNEL -DK_HEAP_MEM_POOL_SIZE=42616 -DMBEDTLS_CONFIG_FILE=\"config-mbedtls.h\" -DNEED_AP_MLME -DTLS_DEFAULT_CIPHERS=\"\"DEFAULT:!EXP:!LOW\"\" -D_POSIX_CLOCK_SELECTION=200809L -D_POSIX_CPUTIME=200809L -D_POSIX_C_SOURCE=200809L -D_POSIX_MONOTONIC_CLOCK=200809L -D_POSIX_REALTIME_SIGNALS=200809L -D_POSIX_THREADS=200809L -D_POSIX_THREAD_SAFE_FUNCTIONS=200809L -D_POSIX_TIMERS=200809L -D__LINUX_ERRNO_EXTENSIONS__ -D__ZEPHYR__=1 -I/__w/zephyr/zephyr/kernel/include -I/__w/zephyr/zephyr/arch/posix/include -I/__w/zephyr/zephyr/modules/hostap/src -I/__w/zephyr/modules/lib/hostap -I/__w/zephyr/modules/lib/hostap/src/utils -I/__w/zephyr/modules/lib/hostap/src/drivers -I/__w/zephyr/modules/lib/hostap/src -I/__w/zephyr/zephyr/include -I/__w/zephyr/zephyr/include/net -I/__w/zephyr/zephyr/tests/net/wifi/configs -I/__w/zephyr/zephyr/twister-out/native_sim_native/host/tests/net/wifi/configs/wifi.build.ap/zephyr/include/generated/zephyr -I/__w/zephyr/zephyr/twister-out/native_sim_native/host/tests/net/wifi/configs/wifi.build.ap/zephyr/include/generated -I/__w/zephyr/zephyr/soc/native/inf_clock -I/__w/zephyr/zephyr/boards/native/native_sim -I/__w/zephyr/zephyr/lib/libc/picolibc/include -I/__w/zephyr/zephyr/include/zephyr/posix -I/__w/zephyr/zephyr/lib/posix/options/getopt -I/__w/zephyr/zephyr/scripts/native_simulator/common/src/include -I/__w/zephyr/zephyr/scripts/native_simulator/native/src/include -I/__w/zephyr/zephyr/subsys/testsuite/include -I/__w/zephyr/zephyr/subsys/shell/modules/kernel_service/thread/.. -I/__w/zephyr/modules/hal/microchip/include -I/__w/zephyr/modules/hal/ti/mspm0/source/ti/devices/msp/. -I/__w/zephyr/modules/hal/ti/mspm0/source/ti/devices/msp/m0p -I/__w/zephyr/modules/hal/ti/mspm0/source/ti/devices/msp/peripherals -I/__w/zephyr/modules/hal/ti/mspm0/source/ti/devices/msp/peripherals/m0p -I/__w/zephyr/modules/hal/ti/mspm0/source/ti/devices/msp/peripherals/m0p/sysctl -I/__w/zephyr/modules/lib/hostap/wpa_supplicant -I/__w/zephyr/modules/lib/hostap/src/common -I/__w/zephyr/modules/lib/hostap/src/eap_common -I/__w/zephyr/modules/lib/hostap/src/eap_server -I/__w/zephyr/modules/lib/hostap/src/radius -I/__w/zephyr/modules/lib/hostap/src/crypto -I/__w/zephyr/modules/lib/hostap/src/ap -I/__w/zephyr/modules/lib/hostap/src/rsn_supp -I/__w/zephyr/modules/lib/hostap/port/mbedtls -I/__w/zephyr/modules/crypto/mbedtls/include -I/__w/zephyr/zephyr/modules/mbedtls/configs -I/__w/zephyr/zephyr/modules/mbedtls/include -isystem /__w/zephyr/zephyr/lib/libc/common/include -isystem /__w/zephyr/zephyr/twister-out/native_sim_native/host/tests/net/wifi/configs/wifi.build.ap/modules/picolibc/picolibc/include -fno-strict-aliasing -Werror -Os -imacros /__w/zephyr/zephyr/twister-out/native_sim_native/host/tests/net/wifi/configs/wifi.build.ap/zephyr/include/generated/zephyr/autoconf.h -fno-common -g -gdwarf-4 -fdiagnostics-color=always -Wall -Wformat -Wformat-security -Wno-format-zero-length -Wdouble-promotion -Wno-pointer-sign -Wpointer-arith -Wexpansion-to-defined -Wno-unused-but-set-variable -Werror=implicit-int -fno-pic -fno-pie -fno-asynchronous-unwind-tables -fno-reorder-functions --param=min-pagesize=0 -fno-defer-pop -fmacro-prefix-map=/__w/zephyr/zephyr/tests/net/wifi/configs=CMAKE_SOURCE_DIR -fmacro-prefix-map=/__w/zephyr/zephyr=ZEPHYR_BASE -fmacro-prefix-map=/__w/zephyr=WEST_TOPDIR -ffunction-sections -fdata-sections -m32 -msse2 -mfpmath=sse -fvisibility=hidden -nostdinc -isystem /usr/lib/gcc/x86_64-linux-gnu/13/include -include /__w/zephyr/zephyr/arch/posix/include/undef_system_defines.h -ffreestanding -fno-builtin -std=c11 -MD -MT zephyr/CMakeFiles/zephyr.dir/__w/zephyr/modules/lib/hostap/src/common/wpa_common.c.obj -MF zephyr/CMakeFiles/zephyr.dir/__w/zephyr/modules/lib/hostap/src/common/wpa_common.c.obj.d -o zephyr/CMakeFiles/zephyr.dir/__w/zephyr/modules/lib/hostap/src/common/wpa_common.c.obj -c /__w/zephyr/modules/lib/hostap/src/common/wpa_common.c
In file included from /__w/zephyr/modules/lib/hostap/src/common/wpa_common.c:9:
/__w/zephyr/modules/lib/hostap/src/utils/includes.h:53:10: fatal error: zephyr/posix/signal.h: No such file or directory
   53 | #include <zephyr/posix/signal.h>
      |          ^~~~~~~~~~~~~~~~~~~~~~~

Impact

Major – Severely degrades functionality; workaround is difficult or unavailable.

Environment

• OS: Ubuntu 22.04
• Toolchain: Zephyr SDK 0.17.4

Additional Context

Failing action: https://github.com/zephyrproject-rtos/zephyr/actions/runs/18005709654?pr=96541

[fabiobaltieri]

The ocpp fix is trivial

diff --git a/samples/net/ocpp/src/main.c b/samples/net/ocpp/src/main.c
index 5e8b8d00794..b703428bce4 100644
--- a/samples/net/ocpp/src/main.c
+++ b/samples/net/ocpp/src/main.c
@@ -5,6 +5,7 @@
  */
 
 #include <stdio.h>
+#include <time.h>
 
 #include <zephyr/net/net_if.h>
 #include <zephyr/net/net_core.h>
@@ -12,7 +13,6 @@
 #include <zephyr/net/net_mgmt.h>
 #include <zephyr/net/sntp.h>
 #include <zephyr/net/ocpp.h>
-#include <zephyr/posix/time.h>
 #include <zephyr/random/random.h>
 #include <zephyr/zbus/zbus.h>

the hostap one seems to be more problematic though, there's quite a few zephyr/posix references in there.

Tried

index 5fd036423..6bf85398a 100644
--- a/src/utils/includes.h
+++ b/src/utils/includes.h
@@ -50,7 +50,7 @@
 #include <zephyr/posix/sys/select.h>
 #include <zephyr/posix/sys/socket.h>
 #include <zephyr/posix/unistd.h>
-#include <zephyr/posix/signal.h>
+#include <zephyr/posix/posix_signal.h>
 #else /* defined(CONFIG_POSIX_API) */
 #include <zephyr/net/socket.h>
 #include <zephyr/net/socket_select.h>

but now I'm getting a

/usr/local/google/home/fabiobaltieri/zephyrproject/zephyr/include/zephyr/posix/posix_signal.h:53:8: error: redefinition of ‘struct timespec’
   53 | struct timespec {
      |        ^~~~~~~~

[pdgendt]

The ocpp fix is trivial

Yes, notice that I avoided mentioning that one in the issue 😅

[cfriedt]

@fabiobaltieri @pdgendt - both <time.h> and <signal.h> can (and should) be included without a prefix now.

[cfriedt]

So far, this for hostap

diff --git a/src/utils/includes.h b/src/utils/includes.h
index 5fd036423..91784ecae 100644
--- a/src/utils/includes.h
+++ b/src/utils/includes.h
@@ -22,8 +22,10 @@
 #include <stdio.h>
 #include <stdarg.h>
 #include <string.h>
-#if !(defined(_WIN32_WCE) || defined(__ZEPHYR__))
+#if !defined(_WIN32_WCE)
 #include <signal.h>
+#endif
+#if !(defined(_WIN32_WCE) || defined(__ZEPHYR__))
 #include <sys/types.h>
 #include <errno.h>
 #endif /* _WIN32_WCE */
@@ -50,7 +52,6 @@
 #include <zephyr/posix/sys/select.h>
 #include <zephyr/posix/sys/socket.h>
 #include <zephyr/posix/unistd.h>
-#include <zephyr/posix/signal.h>
 #else /* defined(CONFIG_POSIX_API) */
 #include <zephyr/net/socket.h>
 #include <zephyr/net/socket_select.h>
diff --git a/src/utils/os_zephyr.c b/src/utils/os_zephyr.c
index 5bd725ca1..387f827e5 100644
--- a/src/utils/os_zephyr.c
+++ b/src/utils/os_zephyr.c
@@ -5,7 +5,8 @@
  * See README for more details.
  */
 
-#include <zephyr/posix/time.h>
+#include <time.h>
+
 #include <zephyr/posix/sys/time.h>
 
 /* The clock_gettime() would be found in <zephyr/posix/time.h> but

The issue I'm running into now is with native_sim and errno.h use. Currently getting:

cd /home/cfriedt/zephyrproject/zephyr/build/zephyr && /usr/bin/make -f /home/cfriedt/zephyrproject/zephyr/scripts/native_simulator/Makefile all --warn-undefined-variables -r NSI_CONFIG_FILE=/home/cfriedt/zephyrproject/zephyr/build/zephyr/NSI/nsi_config
In file included from /usr/include/bits/errno.h:26,
                 from /usr/include/errno.h:28,
                 from /home/cfriedt/zephyrproject/zephyr/scripts/native_simulator//common/src/nce.c:24:
/usr/include/linux/errno.h:1:10: fatal error: asm/errno.h: No such file or directory
    1 | #include <asm/errno.h>
      |          ^~~~~~~~~~~~~
compilation terminated.
make: *** [/home/cfriedt/zephyrproject/zephyr/scripts/native_simulator/Makefile:122: /home/cfriedt/zephyrproject/zephyr/build/zephyr/NSI/common/src/nce.o] Error 1
ninja: build stopped: subcommand failed.
FATAL ERROR: command exited with status 1: /opt/zephyr/venv/20250910/bin/cmake --build /home/cfriedt/zephyrproject/zephyr/build

Looks like scripts/native_simulator/Makefile is just missing something like

CFLAGS += -I${PATH_TO_asm_errno_h}

[cfriedt]

• [noup] zephyr: use standard paths for time.h and signal.h hostap#105
• native_simulator: include folder for missing <asm/errno.h> #96582
• manifest: update hostap module to correct time.h and signal.h paths #96583
• posix: use posix_time.h and posix_signal.h [v2] #96589

[aescolar]

I do not know the context of the issue, but in main doing just this in modules/lib/hostap fixes this report:

diff --git a/src/utils/includes.h b/src/utils/includes.h
index 5fd036423..53b60602f 100644
--- a/src/utils/includes.h
+++ b/src/utils/includes.h
@@ -50,7 +50,7 @@
 #include <zephyr/posix/sys/select.h>
 #include <zephyr/posix/sys/socket.h>
 #include <zephyr/posix/unistd.h>
-#include <zephyr/posix/signal.h>
+#include <signal.h>
 #else /* defined(CONFIG_POSIX_API) */
 #include <zephyr/net/socket.h>
 #include <zephyr/net/socket_select.h>
diff --git a/src/utils/os_zephyr.c b/src/utils/os_zephyr.c
index 5bd725ca1..83ff7098b 100644
--- a/src/utils/os_zephyr.c
+++ b/src/utils/os_zephyr.c
@@ -5,7 +5,7 @@
  * See README for more details.
  */
 
-#include <zephyr/posix/time.h>
+#include <time.h>
 #include <zephyr/posix/sys/time.h>
 
 /* The clock_gettime() would be found in <zephyr/posix/time.h> but

In any case, I'd recommend reverting and calmly looking into what the problem is, instead of doing something hasty.