subsys: net: ip: Support ping times #15327
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's convenient to ping for times. Usage: ping host [times] For example: ping 192.168.1.1 10, this will trigger ping for 10 times. Signed-off-by: Bub Wei <[email protected]>
|
Found the following issues, please fix and resubmit: Gitlint issues1: UC3 Title does not follow [subsystem]: [subject] (and should not start with literal subsys:): "subsys: net: ip: Support ping times" |
easonxiang
approved these changes
Apr 10, 2019
easonxiang
suggested changes
Apr 10, 2019
| PR_WARNING("Cannot send IPv6 ping\n"); | ||
| return -ENOEXEC; | ||
| } | ||
| if (argv[2]) { |
There was a problem hiding this comment.
I'm not sure if argv[i] are set to NULL by default, if not, we need check argc as well.
if ((argc > 2) && argv[2])
There was a problem hiding this comment.
Thanks @easonxiang.
Just refer to argv [1] above.
Well.We might follow another PR Jukkar memtioned.
|
Please check #14024 which is providing already lot of improvements for ping command. |
Sure, it looks nice. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's convenient to ping for times.
Usage:
ping host [times]
For example: ping 192.168.1.1 10, this will trigger ping for 10 times.
Signed-off-by: Bub Wei [email protected]