NXP: CAN: Add LPC MCAN support #35832

henrikbrixandersen · 2021-05-31T20:26:38Z

Add a NXP LPC MCAN-specific front-end for the generic Bosch MCAN driver and enable it for the lpcxpresso55s16 board.

github-actions · 2021-08-05T00:28:40Z

This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time.

dleach02 · 2021-09-28T15:48:56Z

drivers/can/can_mcan.c

So much magic ;-). Just curious but why is this done?

@henrikbrixandersen what will it take to move this PR out of draft state?

I will need to revisit it. As I recall it, there were some issues with CAN-FD with the current solution.

Also, github added an STM32 tag because of the one dts file you touched. Was that your intention because it doesn't really align with the title of the PR.

One of the commits is touching the generic Bosch M-CAN driver, and thus needed to make a change to the STM32 front-end. I still need to decide if this is the right fix.

I found the bug in the generic driver, that I was trying to work-around with the commit that touched the STM32 front-end. I have fixed it properly and removed the STM32 changes + label.

The "magic" above is to calculate the relative addresses of the various elements of the Message RAM.

The addressing part is getting tricky as more front-ends are dropping in.
I propose to merge this as is (and also the new STM32H7) and refactor it.
My idea is to have a function ptr in the config structure that is called somewhere during the init.
Somehow a vendor-specific config.

I propose to merge this as is (and also the new STM32H7) and refactor it.

@alexanderwachter Does that mean you approve this PR?

dleach02 · 2021-10-21T15:52:45Z

@henrikbrixandersen what will it take to move this PR out of draft state?

Also, github added an STM32 tag because of the one dts file you touched. Was that your intention because it doesn't really align with the title of the PR.

github-actions · 2022-01-01T00:29:15Z

This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time.

alexanderwachter

LGTM. Just a little comment. Feel free to ignore it :-)

alexanderwachter · 2022-01-09T14:52:11Z

drivers/can/can_mcan.h

Can we do something like

#define MCAN_DT_PATH DT_COMPAT_GET_ANY_STATUS_OKAY(DT_DRV_COMPAT)

?

The current approach does not allow for different devicetree configurations of the M_CAN message RAM for multiple M_CAN frontend instances, so it needs to be reworked.

I'd prefer to leave this for the general refactoring of the M_CAN driver once the other frontend drivers are in (#41549 and #41674).

The Event FIFO start address (EFSA) field within the Tx event FIFO configuration register (TXEFC) occupies bit 15:2. Change the CAN_MCAN_TXEFC_EFSA_POS definition to reflect this. Signed-off-by: Henrik Brix Andersen <[email protected]>

Add Kconfig option for indicating that a given SoC contains the NXP MCAN CAN FD controller. Signed-off-by: Henrik Brix Andersen <[email protected]>

Add support for the LPC MCAN clock to the LPC SYSCON clock controller driver. Signed-off-by: Henrik Brix Andersen <[email protected]>

Add devicetree binding for the NXP LPC MCAN CAN-FD controller. Signed-off-by: Henrik Brix Andersen <[email protected]>

Add a NXP LPC MCAN-specific front-end for the generic Bosch MCAN driver. Signed-off-by: Henrik Brix Andersen <[email protected]>

Add devicetree node for the NXP LPC MCAN. Signed-off-by: Henrik Brix Andersen <[email protected]>

Add support for the NXP LPC MCAN CAN-FD controller. Signed-off-by: Henrik Brix Andersen <[email protected]>

Add NXP LPC MCAN support for the NXP lpcxpresso55s16 board definition. Fixes zephyrproject-rtos#35437 Signed-off-by: Henrik Brix Andersen <[email protected]>

henrikbrixandersen added platform: NXP NXP area: CAN labels May 31, 2021

github-actions bot added area: API Changes to public APIs area: Boards area: Devicetree area: Devicetree Binding PR modifies or adds a Device Tree binding area: Documentation area: Modules labels May 31, 2021

henrikbrixandersen linked an issue May 31, 2021 that may be closed by this pull request

CAN driver for LPCXpresso55S16 #35437

Closed

henrikbrixandersen force-pushed the lpc_mcan branch 4 times, most recently from 6eff5dc to 5cc5ba5 Compare June 5, 2021 20:55

github-actions bot added the platform: STM32 ST Micro STM32 label Jun 5, 2021

henrikbrixandersen force-pushed the lpc_mcan branch from 5cc5ba5 to c1998e2 Compare June 5, 2021 21:16

henrikbrixandersen mentioned this pull request Jul 15, 2021

drivers: can: mcan: add missing devicetree property for event fifo depth #35989

Closed

github-actions bot added the Stale label Aug 5, 2021

henrikbrixandersen removed the Stale label Aug 5, 2021

dleach02 requested review from dleach02 and mmahadevan108 September 28, 2021 15:46

dleach02 reviewed Sep 28, 2021

View reviewed changes

github-actions bot added the Stale label Jan 1, 2022

henrikbrixandersen removed the Stale label Jan 1, 2022

henrikbrixandersen force-pushed the lpc_mcan branch 4 times, most recently from eed70c1 to 4caa0c4 Compare January 2, 2022 21:28

henrikbrixandersen marked this pull request as ready for review January 3, 2022 09:27

henrikbrixandersen requested review from MaureenHelm, alexanderwachter, carlescufi, galak and nashif as code owners January 3, 2022 09:27

henrikbrixandersen requested a review from martinjaeger January 3, 2022 09:27

henrikbrixandersen force-pushed the lpc_mcan branch from 9606c4c to dd0fa45 Compare January 3, 2022 09:31

henrikbrixandersen mentioned this pull request Jan 3, 2022

CAN driver for LPCXpresso55S16 #35437

Closed

henrikbrixandersen requested a review from Qbicz January 3, 2022 19:42

JeremyBCD mentioned this pull request Jan 3, 2022

drivers: can: stm32: initial CAN/CANFD support for STM32H7 #41549

Merged

dleach02 requested a review from danieldegrasse January 4, 2022 13:58

henrikbrixandersen force-pushed the lpc_mcan branch 2 times, most recently from fc34fb2 to f340363 Compare January 4, 2022 19:48

henrikbrixandersen added this to the v3.0.0 milestone Jan 6, 2022

dleach02 approved these changes Jan 7, 2022

View reviewed changes

alexanderwachter approved these changes Jan 9, 2022

View reviewed changes

henrikbrixandersen added 4 commits January 10, 2022 10:49

modules: mcux: add support for indicating the presence of MCAN

458b22c

Add Kconfig option for indicating that a given SoC contains the NXP MCAN CAN FD controller. Signed-off-by: Henrik Brix Andersen <[email protected]>

drivers: clock_control: lpc: syscon: add MCAN clock support

d38269a

Add support for the LPC MCAN clock to the LPC SYSCON clock controller driver. Signed-off-by: Henrik Brix Andersen <[email protected]>

dts: bindings: can: add NXP LPC MCAN devicetree binding

30b6e4b

Add devicetree binding for the NXP LPC MCAN CAN-FD controller. Signed-off-by: Henrik Brix Andersen <[email protected]>

henrikbrixandersen force-pushed the lpc_mcan branch 2 times, most recently from daf81de to 25ab5a5 Compare January 10, 2022 10:00

henrikbrixandersen added 4 commits January 10, 2022 11:18

drivers: can: add NXP LPC MCAN front-end for the Bosch MCAN driver

7bf390c

Add a NXP LPC MCAN-specific front-end for the generic Bosch MCAN driver. Signed-off-by: Henrik Brix Andersen <[email protected]>

dts: arm: nxp: lpc55S1x: add MCAN devicetree node

81f0b60

Add devicetree node for the NXP LPC MCAN. Signed-off-by: Henrik Brix Andersen <[email protected]>

soc: arm: nxp: lpc55xxx: add MCAN support

47f2b94

Add support for the NXP LPC MCAN CAN-FD controller. Signed-off-by: Henrik Brix Andersen <[email protected]>

boards: arm: lpcxpresso55s16: add MCAN support

21cff9b

Add NXP LPC MCAN support for the NXP lpcxpresso55s16 board definition. Fixes zephyrproject-rtos#35437 Signed-off-by: Henrik Brix Andersen <[email protected]>

henrikbrixandersen force-pushed the lpc_mcan branch from 25ab5a5 to 21cff9b Compare January 10, 2022 10:18

carlescufi merged commit 190c9ba into zephyrproject-rtos:main Jan 10, 2022

henrikbrixandersen deleted the lpc_mcan branch January 10, 2022 12:32

NXP: CAN: Add LPC MCAN support #35832

NXP: CAN: Add LPC MCAN support #35832

Uh oh!

Conversation

henrikbrixandersen commented May 31, 2021

Uh oh!

github-actions bot commented Aug 5, 2021

Uh oh!

dleach02 Sep 28, 2021

Choose a reason for hiding this comment

Uh oh!

henrikbrixandersen Nov 1, 2021

Choose a reason for hiding this comment

Uh oh!

henrikbrixandersen Jan 3, 2022

Choose a reason for hiding this comment

Uh oh!

alexanderwachter Jan 9, 2022

Choose a reason for hiding this comment

Uh oh!

henrikbrixandersen Jan 9, 2022

Choose a reason for hiding this comment

Uh oh!

henrikbrixandersen Jan 9, 2022

Choose a reason for hiding this comment

Uh oh!

dleach02 commented Oct 21, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jan 1, 2022

Uh oh!

alexanderwachter left a comment

Choose a reason for hiding this comment

Uh oh!

alexanderwachter Jan 9, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

henrikbrixandersen Jan 10, 2022

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

dleach02 commented Oct 21, 2021 •

edited

Loading

alexanderwachter Jan 9, 2022 •

edited

Loading