-
Notifications
You must be signed in to change notification settings - Fork 8.2k
boards: arm: Add gd32e103v_eval board #36833
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
boards: arm: Add gd32e103v_eval board #36833
Conversation
|
The following west manifest projects have been modified in this Pull Request:
Note: This message is automatically posted and updated by the Manifest GitHub Action. |
e018417 to
7995b36
Compare
|
@feilongfl thank you for this PR. Regarding the In general the policy is: if it's written exclusively for Zephyr it should be in the main zephyr tree. If it's part of a cross-RTOS HAL or library that is published separately then it belongs in the external module repo. |
Could you please describe in the main body of this PR where this code comes from? |
I got it, i will move these
most of these code was download from |
|
Hi @carlescufi , Do you think Zephyr project can add at least hal_gigadevice ? I have an gd32f403 minimal working too. It was just a test but I can clean up e fix docs and that can be very useful. GigaDevices ARM firmwares are pretty easy to be used with Zephyr.
GigaDevices provides a firmware library and tools for all ARM and RISC-V at GigaDevices Download Site . |
58d05f5 to
63f9552
Compare
|
I've move |
5817ee5 to
062249d
Compare
|
I've migrated this pr to latest main branch. If somewhere need modify, just let me know. |
nandojve
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @feilongfl !
Two comments only.
c7419a7 to
b7b539a
Compare
Update the hal_gigadevice revirsion which support gd32e10x HAL. Signed-off-by: YuLong Yao <[email protected]>
add soc.h include in pinctrl_gd32_afio.c Signed-off-by: YuLong Yao <[email protected]>
Add support for GigaDevice gd32e10x series. Signed-off-by: YuLong Yao <[email protected]>
Add support for the E10x series. Signed-off-by: YuLong Yao <[email protected]>
Add gigadevice gd32e103v_eval board initial version. Signed-off-by: YuLong Yao <[email protected]>
b7b539a to
4271540
Compare
gmarull
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, a couple of minor comments before approval
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should be:
group1 {
pinmux = <I2C0_SCL_PB6_NORMP>, <I2C0_SDA_PB7_NORMP>;
drive-open-drain;
};
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Although the eval board SCL have pull-up resistors, but I'm not sure as IIC master, does SCL needs to be open-drain?
😕
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You still need it, e.g. for https://www.i2c-bus.org/clock-stretching/
set HAXTL_VALUE to GD32_HXTAL_8MHZ for gd32_e103. Signed-off-by: YuLong Yao <[email protected]>
add exti for gd32e103 Signed-off-by: YuLong Yao <[email protected]>
add `gpio-controller` property to gpio node. Signed-off-by: YuLong Yao <[email protected]>
add 4x leds and 3x button for eval board. Signed-off-by: YuLong Yao <[email protected]>
add timer and pwm into dts. Signed-off-by: YuLong Yao <[email protected]>
add 1x pwmled. Signed-off-by: YuLong Yao <[email protected]>
add i2c node in dts. Signed-off-by: YuLong Yao <[email protected]>
add support for at24 eeprom. Signed-off-by: YuLong Yao <[email protected]>
enable dac. Signed-off-by: YuLong Yao <[email protected]>
add dac support. Signed-off-by: YuLong Yao <[email protected]>
4271540 to
c077ab3
Compare
nandojve
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @feilongfl,
Thank you so much.
tianrking
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR adds support for GigaDevice GD32E103VBT6 SoC and GD32E103V-EVAL board that is use the SoC.
Currently, the west module dependency points to https://github.com/feilongfl/hal_gd32 (most of these code was download from gigadevice's website, -> Documents & Software -> Firmware Library)
I'm not sure where can I put these code,I found another issues #34971 have gigadevice RISKV device,but I think it's not good to put code there.
At this time, Only
samples/basic/blinkyis work.And lots of code is copy fromstm32, So some code is not necessary.I'll remove them later.