Skip to content

linker: aarch32: automatic derivation of region names from devicetree nodes #37279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Dec 9, 2021
Merged

linker: aarch32: automatic derivation of region names from devicetree nodes #37279

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
e06bc25
dts: bindings: `zephyr,linker-region` property
Jul 28, 2021
cebc913
scripts: gen_defines: zephyr,linker-region unique
Jul 28, 2021
29f510c
devicetree: `LINKER_DT_NODE_REGION_NAME` added
Jul 28, 2021
fe500bb
tests: devicetree: test LINKER_DT_NODE_REGION_NAME
Aug 1, 2021
a290d99
linker: remove manual name specification
Jun 17, 2021
a55b6e4
cmake: `zephyr_linker_dts_memory` auto-name
Dec 9, 2021
773c637
cmake: `zephyr_linker_dts_memory` no name param
Dec 9, 2021
4846b0d
dts: linker region properties
Jul 28, 2021
47646a5
linker: link into derived section names
Jul 28, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion cmake/extensions.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3377,9 +3377,14 @@ function(zephyr_linker_dts_memory)

dt_reg_addr(addr PATH ${DTS_MEMORY_PATH})
dt_reg_size(size PATH ${DTS_MEMORY_PATH})
dt_prop(name PATH ${DTS_MEMORY_PATH} PROPERTY "memory-region")
if (NOT DEFINED name)
# Fallback to the node path
set(name ${DTS_MEMORY_PATH})
endif()
Comment on lines +3380 to +3383
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor nit, it's possible to do:

Suggested change
if (NOT DEFINED name)
# Fallback to the node path
set(name ${DTS_MEMORY_PATH})
endif()
set_ifndef(name ${DTS_MEMORY_PATH})

zephyr/cmake/extensions.cmake

Line 1619 in 92fbd7d

function(set_ifndef variable value)


zephyr_linker_memory(
NAME ${DTS_MEMORY_NAME}
NAME ${name}
START ${addr}
SIZE ${size}
FLAGS ${DTS_MEMORY_FLAGS}
Expand Down