Skip to content

linker: aarch32: automatic derivation of region names from devicetree nodes #37279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Dec 9, 2021
+276 −60
Merged

linker: aarch32: automatic derivation of region names from devicetree nodes #37279

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
e06bc25
dts: bindings: `zephyr,linker-region` property
Jul 28, 2021
cebc913
scripts: gen_defines: zephyr,linker-region unique
Jul 28, 2021
29f510c
devicetree: `LINKER_DT_NODE_REGION_NAME` added
Jul 28, 2021
fe500bb
tests: devicetree: test LINKER_DT_NODE_REGION_NAME
Aug 1, 2021
a290d99
linker: remove manual name specification
Jun 17, 2021
a55b6e4
cmake: `zephyr_linker_dts_memory` auto-name
Dec 9, 2021
773c637
cmake: `zephyr_linker_dts_memory` no name param
Dec 9, 2021
4846b0d
dts: linker region properties
Jul 28, 2021
47646a5
linker: link into derived section names
Jul 28, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dts/bindings/arm/arm,dtcm.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ description: Cortex-M DTCM (Data Tightly Coupled Memory)

compatible: "arm,dtcm"

include: base.yaml
include: [base.yaml, mem-region.yaml]

properties:
reg:
Expand Down
2 changes: 1 addition & 1 deletion dts/bindings/arm/arm,itcm.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ description: Cortex-M ITCM (Instruction Tightly Coupled Memory)

compatible: "arm,itcm"

include: base.yaml
include: [base.yaml, mem-region.yaml]

properties:
reg:
Expand Down
2 changes: 1 addition & 1 deletion dts/bindings/arm/nxp,imx-dtcm.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ description: i.MX DTCM (Data Tightly Coupled Memory)

compatible: "nxp,imx-dtcm"

include: base.yaml
include: [base.yaml, mem-region.yaml]

properties:
reg:
Expand Down
2 changes: 1 addition & 1 deletion dts/bindings/arm/nxp,imx-itcm.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ description: i.MX ITCM (Instruction Tightly Coupled Memory)

compatible: "nxp,imx-itcm"

include: base.yaml
include: [base.yaml, mem-region.yaml]

properties:
reg:
Expand Down
13 changes: 13 additions & 0 deletions dts/bindings/base/mem-region.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
# Copyright (c) 2021, CSIRO
# SPDX-License-Identifier: Apache-2.0
# Common fields for devices resulting in linker memory regions

properties:
zephyr,memory-region:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing wrong on this line but with the latest update you are now using memory-region
👍 to that :)

But the commit message still says e06bc25:

dts: bindings: zephyr,linker-region property

Introduce optional zephyr,linker-region property

Note: same goes for some other commit messages.

type: string
required: false
description: |
Signify that this node should result in a dedicated linker script
memory region in the final executable. The region address and size
is taken from the <reg> property, while the name is the value of
this property.
2 changes: 1 addition & 1 deletion dts/bindings/memory-controllers/st,stm32-backup-sram.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ description: |

compatible: "st,stm32-backup-sram"

include: base.yaml
include: [base.yaml, mem-region.yaml]

properties:
label:
Expand Down
9 changes: 9 additions & 0 deletions dts/bindings/mtd/fixed-partitions.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,3 +28,12 @@ child-binding:
type: array
description: register space
required: true
zephyr,memory-region:
type: string
required: false
description: |
Signify that this node should result in a dedicated linker script
memory region in the final executable. The region address and size
is taken from the <reg> property, while the name is the value of
this property. This must only be added to memory-mapped partitions,
not partitions on external flash.
2 changes: 1 addition & 1 deletion dts/bindings/sram/mmio-sram.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ description: Generic on-chip SRAM description

compatible: "mmio-sram"

include: base.yaml
include: [base.yaml, mem-region.yaml]

properties:
reg:
Expand Down