Skip to content

Conversation

@mbolivar-nordic
Copy link
Contributor

The main motivation is to avoid polluting the all-caps "DT_"
namespace, which within zephyr belongs to devicetree.h.

Signed-off-by: Martí Bolívar [email protected]

@github-actions github-actions bot added area: API Changes to public APIs area: ARM ARM (32-bit) Architecture labels Aug 5, 2021
@mbolivar-nordic mbolivar-nordic force-pushed the linker-regions-dt-namespace branch from 7cdc7ce to e9740ba Compare August 5, 2021 23:24
@mbolivar-nordic
Copy link
Contributor Author

@JordanYates feel free to take this patch into #37279 to get the rename and the enhancements all in one go.

Copy link
Contributor

@JordanYates JordanYates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me. An argument could be made for LINKER_DT_REGION_FROM_NODE to conform to the GPIO_DT_SPEC_* kind of naming convention, but i'm not sure how much of those names are because they're constructing a *_dt_spec structure.
I don't mind either way

The main motivation is to avoid polluting the all-caps "DT_"
namespace, which within zephyr belongs to devicetree.h.

Signed-off-by: Martí Bolívar <[email protected]>
@mbolivar-nordic mbolivar-nordic force-pushed the linker-regions-dt-namespace branch from e9740ba to 5e52076 Compare August 6, 2021 17:23
@mbolivar-nordic
Copy link
Contributor Author

An argument could be made for LINKER_DT_REGION_FROM_NODE

Sure, done.

@cfriedt cfriedt merged commit d1eee6a into zephyrproject-rtos:main Aug 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: API Changes to public APIs area: ARM ARM (32-bit) Architecture

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants