-
Notifications
You must be signed in to change notification settings - Fork 8.2k
scripts: runner: Introduce blflash runner #38851
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
scripts: runner: Introduce blflash runner #38851
Conversation
Add Bouffalo Lab ISP console flash runner. This tool enable bootloader to flash devices using serial port. The blflash Rust tool can be found at https://github.com/spacemeowx2/blflash Signed-off-by: Gerson Fernando Budke <[email protected]>
54aa233 to
9b71b9d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this PR needed ?
I don't see any boards using this flash runner.
Also, I feel some documentation is missing, either in a board description for a board using this runner or as a description of the runner itself.
It can be used with Bouffalo Lab SoCs. #37686
Agreed, I'll step back and improve a little bit more. |
Thanks for the link. Would have been nice with a link to #37686 and some description in this PR's top comment. |
|
This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, looks nice and simple. I'd prefer to see this merged along with the PR that uses the runner in a board, along with some test cases, if you have time.
| help='path to blflash, default is blflash') | ||
| parser.add_argument('--port', default=DEFAULT_BLFLASH_PORT, | ||
| help='serial port to use, default is ' + | ||
| str(DEFAULT_BLFLASH_PORT)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is already a str, no need to call str here.
Add Bouffalo Lab ISP console flash runner. This tool enable bootloader to flash devices using serial port.
The blflash Rust tool can be found at
https://github.com/spacemeowx2/blflash
Signed-off-by: Gerson Fernando Budke [email protected]