Skip to content

Conversation

@nandojve
Copy link
Member

Add Bouffalo Lab ISP console flash runner. This tool enable bootloader to flash devices using serial port.

The blflash Rust tool can be found at
https://github.com/spacemeowx2/blflash

Signed-off-by: Gerson Fernando Budke [email protected]

Add Bouffalo Lab ISP console flash runner.  This tool enable bootloader
to flash devices using serial port.

The blflash Rust tool can be found at
  https://github.com/spacemeowx2/blflash

Signed-off-by: Gerson Fernando Budke <[email protected]>
Copy link
Contributor

@tejlmand tejlmand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this PR needed ?

I don't see any boards using this flash runner.

Also, I feel some documentation is missing, either in a board description for a board using this runner or as a description of the runner itself.

@nandojve
Copy link
Member Author

Why is this PR needed ?

It can be used with Bouffalo Lab SoCs. #37686
Currently, there is no dependencies to this runner.

I don't see any boards using this flash runner.

Also, I feel some documentation is missing, either in a board description for a board using this runner or as a description of the runner itself.

Agreed, I'll step back and improve a little bit more.

@nandojve nandojve marked this pull request as draft October 19, 2021 14:05
@tejlmand
Copy link
Contributor

Why is this PR needed ?

It can be used with Bouffalo Lab SoCs. #37686

Thanks for the link.
Make sense to have this open, and as a draft as you just did.

Would have been nice with a link to #37686 and some description in this PR's top comment.
Would have made the purpose and background of this PR clearer.

@github-actions
Copy link

github-actions bot commented Jan 9, 2022

This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time.

@github-actions github-actions bot added the Stale label Jan 9, 2022
Copy link
Contributor

@mbolivar-nordic mbolivar-nordic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, looks nice and simple. I'd prefer to see this merged along with the PR that uses the runner in a board, along with some test cases, if you have time.

help='path to blflash, default is blflash')
parser.add_argument('--port', default=DEFAULT_BLFLASH_PORT,
help='serial port to use, default is ' +
str(DEFAULT_BLFLASH_PORT))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is already a str, no need to call str here.

@github-actions github-actions bot closed this Jan 28, 2022
@nandojve nandojve deleted the bl_zephyr_blflash_runner branch February 2, 2022 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants