Skip to content

Conversation

@rustypig91
Copy link
Contributor

@rustypig91 rustypig91 commented Sep 27, 2021

PR #38482 made the sam0 i2c send NACK when receiving a single message

Fixes #38878
Fixes #41016

Signed-off-by: Christoffer Zakrisson [email protected]

@github-actions
Copy link

This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time.

@github-actions github-actions bot added the Stale label Nov 27, 2021
@nandojve nandojve requested review from mnkp and nandojve November 27, 2021 00:52
@nandojve nandojve added the platform: Microchip SAM Microchip SAM Platform (formerly Atmel SAM) label Nov 27, 2021
@nandojve
Copy link
Member

Hi @rustypig91 ,

Can you rebase?

@nandojve nandojve requested a review from stephanosio November 27, 2021 00:54
@rustypig91 rustypig91 force-pushed the fix_sam0_i2c_continue_next branch from 3ade430 to 9870830 Compare November 27, 2021 11:46
@github-actions github-actions bot removed the Stale label Nov 28, 2021
@maxmclau
Copy link
Contributor

maxmclau commented Dec 9, 2021

This seems to clear up my issue #41016.

@nandojve
Copy link
Member

nandojve commented Dec 9, 2021

Hi @rustypig91 ,
Could include at commit msg 41016? This allow us to close 2 issues and have their references.

PR zephyrproject-rtos#38482 made the sam0 i2c send NACK when receiving a single message

Fixes zephyrproject-rtos#38878
Fixes zephyrproject-rtos#41016

Signed-off-by: Christoffer Zakrisson <[email protected]>
@rustypig91 rustypig91 force-pushed the fix_sam0_i2c_continue_next branch from 9870830 to 0f24a0c Compare December 12, 2021 07:36
Copy link
Member

@nandojve nandojve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tks @rustypig91 !

@nandojve nandojve added this to the v3.0.0 milestone Dec 20, 2021
@cfriedt cfriedt merged commit 8367df2 into zephyrproject-rtos:main Jan 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: I2C platform: Microchip SAM Microchip SAM Platform (formerly Atmel SAM)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

i2c_sam0.c i2c_sam0_transfer operations do not execute a STOP drivers: i2c: sam0: multiple edge case failures

6 participants