Skip to content

soc: arm: stm32h7: implement workaround for AXI SRAM data corruption #38981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 21, 2021
Merged

soc: arm: stm32h7: implement workaround for AXI SRAM data corruption #38981

merged 1 commit into from
Oct 21, 2021

Conversation

@ABOSTM
Copy link
Contributor

@ABOSTM ABOSTM commented Sep 29, 2021

soc: arm: stm32h7: implement workaround for AXI SRAM data corruption

Errata ES0392 Rev 8:
2.2.9: Reading from AXI SRAM may lead to data read corruption
Workaround: Set the READ_ISS_OVERRIDE bit in the AXI_TARG7_FN_MOD
register.
Applicable only to RevY (REV_ID 0x1003)

Fixes #38933

@ABOSTM ABOSTM added bug The issue is a bug, or the PR is fixing a bug platform: STM32 ST Micro STM32 labels Sep 29, 2021
@ABOSTM ABOSTM requested review from FRASTM and erwango September 29, 2021 14:59
@ABOSTM ABOSTM mentioned this pull request Sep 29, 2021
Closed
@erwango
Copy link
Member

erwango commented Sep 30, 2021

@flo-carrere, would you mind to formally review (and approve) this PR?

@flo-carrere
Copy link

flo-carrere commented Sep 30, 2021

@erwango
I reviewed the change and tested it locally as stated in #38933 conversation.

How should I do to approve it?
Would you add me to pending reviewer then?

@erwango
Copy link
Member

erwango commented Sep 30, 2021

@erwango I reviewed the change and tested it locally as stated in #38933 conversation.

How should I do to approve it? Would you add me to pending reviewer then?

Github allows anyone to review any PR.
You just need to go and see the code change and hit the green "review change" button at the top right hand (click "appprove" if satisfied). The reason we care (that you do it here and not in the issue) is that at least two approvals are required to allow a PR to be merged.

@erwango erwango added this to the v3.0.0 milestone Sep 30, 2021
flo-carrere
flo-carrere approved these changes Sep 30, 2021
View reviewed changes
Copy link

@flo-carrere flo-carrere left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally on OpenMV Cam H7 board (built around STM32H743VI rev. Y) using Zephyr 2.6.0 patched with the workaround.

I confirm the change solves the problem as expected.

@ABOSTM ABOSTM force-pushed the ERRATA_H7_AXI_DATA_CORRUPTION branch from 8c434fa to 9c9911f Compare October 1, 2021 15:34
@ABOSTM
soc: arm: stm32h7: implement workaround for AXI SRAM data corruption
10bca87 
Errata ES0392 Rev 8:
2.2.9: Reading from AXI SRAM may lead to data read corruption
Workaround: Set the READ_ISS_OVERRIDE bit in the AXI_TARG7_FN_MOD
register.
This is applicable only to RevY (REV_ID 0x1003)

Fixes zephyrproject-rtos#38933

Signed-off-by: Alexandre Bourdiol <[email protected]>
@ABOSTM ABOSTM force-pushed the ERRATA_H7_AXI_DATA_CORRUPTION branch from 9c9911f to 10bca87 Compare October 11, 2021 13:22
@nashif nashif merged commit 2d4b1b6 into zephyrproject-rtos:main Oct 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erwango erwango erwango approved these changes

@FRASTM FRASTM FRASTM approved these changes

+1 more reviewer

@flo-carrere flo-carrere flo-carrere approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@erwango erwango

Labels

bug The issue is a bug, or the PR is fixing a bug platform: STM32 ST Micro STM32

Projects

None yet

Milestone

v3.0.0

Development

Successfully merging this pull request may close these issues.

Implement a workaround for STM32H743VI (Rev. Y) - preventing unexpected memory corruption when reading from AXI SRAM

5 participants

@ABOSTM @erwango @flo-carrere @FRASTM @nashif