drivers: gpio: move non-standard dts flags to be soc specific #39767

henrikbrixandersen · 2021-10-27T12:55:48Z

Reserve the upper 8 bits of gpio_dt_flags_t for SoC specific flags and move the non-standard, hardware-specific GPIO devicetree flags (IO voltage level, drive strength, debounce filter) from the generic dt-bindings/gpio/gpio.h header to SoC specific dt-bindings headers.

Some of the SoC specific dt-bindings flags take up more bits than necessary in order to retain backwards compatibility with the deprecated GPIO flags. The width of these fields can be reduced/optimized once the deprecated flags are removed.

Remove hardcoded use of GPIO_INT_DEBOUNCE in GPIO client drivers. This flag can now be set in the devicetree for boards/SoCs with debounce filter support. The SoC specific debounce flags have had the _INT part of their name removed since these flag must be passed to gpio_pin_configure(), not gpio_pin_interrupt_configure().

Signed-off-by: Henrik Brix Andersen [email protected]

keith-zephyr

If the dt-bindings are going to be extended, I think all the GPIO flags should be moved into the dt-bindings instead of just the drive strength flags.

include/dt-bindings/gpio/gpio.h

carlescufi · 2021-11-02T16:15:47Z

API meeting:

Concern as to there is duplication between pinctrl standard properties and the macros in this Pull Request
The pinctrl node is not used for pure GPIOs, hence there is no duplication possible. This is already documented here: https://docs.zephyrproject.org/latest/guides/pinctrl/index.html#pin-control-vs-gpio

include/dt-bindings/gpio/gpio.h

carlescufi · 2021-11-09T11:44:24Z

@henrikbrixandersen ping

keith-zephyr · 2022-01-18T22:40:06Z

I'd like to see this change get approved. What's the current status of this PR?

henrikbrixandersen · 2022-01-19T11:16:33Z

I'd like to see this change get approved. What's the current status of this PR?

@keith-zephyr Thanks for reminding me. I have updated this PR to extend the size of gpio_dt_flags_t from 8 to 16 bits and moved the flags accordingly.

Removing my blocking vote.

carlescufi · 2022-01-24T16:16:39Z

@mnkp @gmarull @mbolivar-nordic please take a look

gmarull

LGTM. In some cases, like nRF, we can now offer more meaningful options for the users. Will look at it after this gets in.

mbolivar-nordic

We need an index of device drivers in the documentation that includes information on driver-specific features more than ever with changes like this going in...

mnkp

Thanks @henrikbrixandersen, great work! I have some minor but blocking comments. Also, I think we should squash "drivers: gpio: allow specifying GPIO drive strength/debounce flags in dts" commit. I.e. implement all the changes in a single commit.

include/drivers/gpio.h

henrikbrixandersen · 2022-02-22T09:42:24Z

Thanks @henrikbrixandersen, great work! I have some minor but blocking comments. Also, I think we should squash "drivers: gpio: allow specifying GPIO drive strength/debounce flags in dts" commit. I.e. implement all the changes in a single commit.

@mnkp Thank you for reviewing. I have squashed the two commits into one. Please see my question on how you'd like to handle deprecation of the old macros.

henrikbrixandersen · 2022-02-28T09:55:25Z

@mnkp Ping?

anangl · 2022-03-08T10:14:57Z

drivers/gpio/gpio_andes_atcgpio100.c

I think we should get rid of this misleading INT_ component from the names of debounce flags. Unlike all other GPIO_INT_* flags, the debounce flag is supposed to be used in calls to gpio_pin_configure(), not gpio_pin_interrupt_configure().

@anangl Thank you for reviewing. I have removed the _INT part of the name for the SoC specific debounce flags.

Reserve the upper 8 bits of gpio_dt_flags_t for SoC specific flags and move the non-standard, hardware-specific GPIO devicetree flags (IO voltage level, drive strength, debounce filter) from the generic dt-bindings/gpio/gpio.h header to SoC specific dt-bindings headers. Some of the SoC specific dt-bindings flags take up more bits than necessary in order to retain backwards compatibility with the deprecated GPIO flags. The width of these fields can be reduced/optimized once the deprecated flags are removed. Remove hardcoded use of GPIO_INT_DEBOUNCE in GPIO client drivers. This flag can now be set in the devicetree for boards/SoCs with debounce filter support. The SoC specific debounce flags have had the _INT part of their name removed since these flag must be passed to gpio_pin_configure(), not gpio_pin_interrupt_configure(). Signed-off-by: Henrik Brix Andersen <[email protected]>

include/dt-bindings/gpio/gpio.h

henrikbrixandersen added area: GPIO area: Devicetree labels Oct 27, 2021

henrikbrixandersen requested review from MaureenHelm, carlescufi, galak and nashif as code owners October 27, 2021 12:55

github-actions bot added area: API Changes to public APIs area: Devicetree Binding PR modifies or adds a Device Tree binding labels Oct 27, 2021

zephyrbot requested a review from mnkp October 28, 2021 12:04

zephyrbot assigned mnkp Oct 28, 2021

keith-zephyr previously requested changes Nov 2, 2021

View reviewed changes

include/dt-bindings/gpio/gpio.h Outdated Show resolved Hide resolved

keith-zephyr requested a review from brockus-zephyr November 2, 2021 15:39

galak reviewed Nov 2, 2021

View reviewed changes

include/dt-bindings/gpio/gpio.h Outdated Show resolved Hide resolved

henrikbrixandersen marked this pull request as draft November 30, 2021 17:31

henrikbrixandersen force-pushed the gpio_ds_flags_dts branch 3 times, most recently from a6e0693 to 2756a23 Compare January 19, 2022 11:02

henrikbrixandersen marked this pull request as ready for review January 19, 2022 11:13

henrikbrixandersen requested a review from keith-zephyr January 19, 2022 11:14

henrikbrixandersen requested a review from galak January 19, 2022 11:16

henrikbrixandersen added the dev-review To be discussed in dev-review meeting label Jan 20, 2022

henrikbrixandersen requested a review from mbolivar-nordic January 20, 2022 16:33

henrikbrixandersen removed the dev-review To be discussed in dev-review meeting label Jan 20, 2022

carlescufi requested a review from gmarull January 24, 2022 16:16

gmarull previously approved these changes Feb 17, 2022

View reviewed changes

mbolivar-nordic previously approved these changes Feb 17, 2022

View reviewed changes

mnkp requested changes Feb 22, 2022

View reviewed changes

include/drivers/gpio.h Outdated Show resolved Hide resolved

henrikbrixandersen dismissed stale reviews from mbolivar-nordic and gmarull via be47c29 February 22, 2022 09:41

henrikbrixandersen force-pushed the gpio_ds_flags_dts branch from 2879637 to be47c29 Compare February 22, 2022 09:41

henrikbrixandersen requested a review from mnkp February 22, 2022 09:42

brockus-zephyr previously approved these changes Feb 22, 2022

View reviewed changes

henrikbrixandersen added this to the v3.1.0 milestone Mar 2, 2022

henrikbrixandersen mentioned this pull request Mar 8, 2022

drivers: gpio_pcal6408a: Fix handling of the GPIO_INT_DEBOUNCE flag #43436

Merged

anangl reviewed Mar 8, 2022

View reviewed changes

henrikbrixandersen dismissed brockus-zephyr’s stale review via 828b677 March 9, 2022 12:37

henrikbrixandersen force-pushed the gpio_ds_flags_dts branch from be47c29 to 828b677 Compare March 9, 2022 12:37

henrikbrixandersen requested review from anangl, brockus-zephyr, gmarull and mbolivar-nordic March 9, 2022 12:39

gmarull previously approved these changes Mar 9, 2022

View reviewed changes

henrikbrixandersen dismissed gmarull’s stale review via c061702 March 9, 2022 12:48

henrikbrixandersen force-pushed the gpio_ds_flags_dts branch from 828b677 to c061702 Compare March 9, 2022 12:48

henrikbrixandersen requested a review from gmarull March 9, 2022 12:49

gmarull approved these changes Mar 9, 2022

View reviewed changes

anangl approved these changes Mar 9, 2022

View reviewed changes

include/dt-bindings/gpio/gpio.h Show resolved Hide resolved

mnkp approved these changes Mar 9, 2022

View reviewed changes

nashif merged commit d4023b3 into zephyrproject-rtos:main Mar 10, 2022

henrikbrixandersen deleted the gpio_ds_flags_dts branch March 15, 2022 15:37

FRASTM mentioned this pull request Mar 17, 2022

stm32: pwm driver enables complementary output for timer channel #42119

Merged

drivers: gpio: move non-standard dts flags to be soc specific #39767

drivers: gpio: move non-standard dts flags to be soc specific #39767

Uh oh!

Conversation

henrikbrixandersen commented Oct 27, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

keith-zephyr left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

carlescufi commented Nov 2, 2021

Uh oh!

Uh oh!

carlescufi commented Nov 9, 2021

Uh oh!

keith-zephyr commented Jan 18, 2022

Uh oh!

henrikbrixandersen commented Jan 19, 2022

Uh oh!

carlescufi commented Jan 24, 2022

Uh oh!

gmarull left a comment

Choose a reason for hiding this comment

Uh oh!

mbolivar-nordic left a comment

Choose a reason for hiding this comment

Uh oh!

mnkp left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

henrikbrixandersen commented Feb 22, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

henrikbrixandersen commented Feb 28, 2022

Uh oh!

anangl Mar 8, 2022

Choose a reason for hiding this comment

Uh oh!

henrikbrixandersen Mar 9, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

henrikbrixandersen commented Oct 27, 2021 •

edited

Loading

henrikbrixandersen commented Feb 22, 2022 •

edited

Loading