drivers: serial: gd32: Add interrupt support #39897
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area: Boards
area: Devicetree
area: Devicetree Binding
This was referenced Oct 29, 2021
cameled
force-pushed
the
usart-gd32
branch
3 times, most recently
from
f6c2694 to
59333ff
Compare
nandojve
requested changes
Nov 10, 2021
Member
nandojve
left a comment
nandojve
left a comment
There was a problem hiding this comment.
Hi @cameled ,
In general, LGTM, only nits with style. This is very important to keep code easy to read. Please, look resolved conversations and review it (I'm unable to set as unresolved).
Alignment is made with TAB (most you can) + spaces.
cameled
force-pushed
the
usart-gd32
branch
2 times, most recently
from
da2fde8 to
f4a0779
Compare
gmarull
requested changes
Nov 12, 2021
Member
gmarull
left a comment
gmarull
left a comment
There was a problem hiding this comment.
overall LGTM, some minor changes requested
gmarull
approved these changes
Nov 14, 2021
nandojve
changed the title
Member
|
Hello @cameled , can you rebase and push again to check if we get CI green? |
gmarull
reviewed
Nov 22, 2021
Initialize parity bit(Default NONE) from DTS. Signed-off-by: HaiLong Yang <[email protected]>
Contributor
Author
Add interrupt support for gd32 usart driver. Signed-off-by: HaiLong Yang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add interrupt supprot for gd32 usart driver.
Note: