boards: arm: GD32F450I-EVAL: add initial support #39958
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area: Boards
area: Devicetree
area: Documentation
area: Modules
manifest
west
manifest-hal_gigadevice
DNM
|
The following west manifest projects have been modified in this Pull Request:
Note: This message is automatically posted and updated by the Manifest GitHub Action. |
gmarull
force-pushed
the
gd32f450
branch
2 times, most recently
from
c596718 to
37d16c0
Compare
This was referenced Nov 1, 2021
cameled
reviewed
Nov 11, 2021
2 tasks
Despite the "F4" prefix, GD32F403 is an SoC with significant differences compared to other F4 MCUs: - It has a completely different HAL - It has significant hardware differences, for example, the pinctrl mechanism uses AFIO (all others use AF) The grouping principles applied to other similar vendors such as ST can't be applied for GD32 due to these reasons, so the approach taken here is to define series based on the used HAL. A different HAL likely means that there are significant hardware differences between, e.g. F403 and F405. The vendor likely chose a confusing naming scheme, but we need to deal with it. Signed-off-by: Gerard Marull-Paretas <[email protected]>
There is no need to specify SoC suffixes, so simplify the selection. Signed-off-by: Gerard Marull-Paretas <[email protected]>
- Remove unnecessary include guard - Fix comments Signed-off-by: Gerard Marull-Paretas <[email protected]>
Adjust CMake according to latest SoC changes. Signed-off-by: Gerard Marull-Paretas <[email protected]>
Create a folder for each of the series. Signed-off-by: Gerard Marull-Paretas <[email protected]>
Update hal_gigadevice, required to make F4XX HAL available. Signed-off-by: Gerard Marull-Paretas <[email protected]>
GD32F4XX requires access to SoC definitions (e.g. GD32F450) when including library header files, so expose them at Zephyr level. Signed-off-by: Gerard Marull-Paretas <[email protected]>
Add missing drivers included in F4XX HAL: - DCI - IPA - IREF - SYSCFG - TLI - TRNG Signed-off-by: Gerard Marull-Paretas <[email protected]>
Add initial support for GD32F4XX (405, 407 and 450). Signed-off-by: Gerard Marull-Paretas <[email protected]>
Add support for the IK variant (256K SRAM, 3072K ROM). Signed-off-by: Gerard Marull-Paretas <[email protected]>
Add support for the F4XX series. Signed-off-by: Gerard Marull-Paretas <[email protected]>
Add initial support for the GD32F450I-EVAL board. Signed-off-by: Gerard Marull-Paretas <[email protected]>
martinjaeger
approved these changes
Nov 18, 2021
Member
martinjaeger
left a comment
martinjaeger
left a comment
There was a problem hiding this comment.
PR looks good. Haven't worked with this particular MCU series, though, and I didn't double-check with the reference manual.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds initial support for the GD32F450I-EVAL board. It also includes some refactoring to the
hal_gigadevicemodule and SoC/dts organization to accommodate addition of new series. Each commit contains more information/details on the changes performed.Note: I'll open a separate PR for the
pinctrldriver, for now, the board has a custom init function.