SPI API: frame format configuration option (TI vs Motorola) #39990
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbursztyka
requested review from
MaureenHelm,
Vudentz,
albertofloyd,
avisconti,
glaubermaroto,
jhedberg,
joerchan,
karstenkoenig,
loicpoulain,
mbolivar-nordic,
mnkp,
nashif,
nvlsianpu and
vanwinkeljan
as code owners
github-actions
bot
added
area: SPI
tbursztyka
added
DNM
tbursztyka
changed the title
7 tasks
tbursztyka
force-pushed
the
spi_motorola_ti
branch
from
3d3c1b7 to
52beff6
Compare
carlescufi
reviewed
Nov 9, 2021
tbursztyka
force-pushed
the
spi_motorola_ti
branch
2 times, most recently
from
a61e54a to
0985d86
Compare
tbursztyka
force-pushed
the
spi_motorola_ti
branch
5 times, most recently
from
e78aca2 to
4c1291f
Compare
tbursztyka
force-pushed
the
spi_motorola_ti
branch
from
4c1291f to
2d37f94
Compare
github-actions
bot
added
the
area: Devicetree Binding
tbursztyka
changed the title
tbursztyka
force-pushed
the
spi_motorola_ti
branch
2 times, most recently
from
baf8a70 to
e87d945
Compare
erwango
reviewed
Nov 23, 2021
erwango
reviewed
Nov 23, 2021
erwango
reviewed
Nov 23, 2021
erwango
reviewed
Nov 23, 2021
added 2 commits
November 24, 2021 08:21
So TI will no longer be the only frame format available, though it will still be the default one. It will be possible to select the Motorola frame format when relevant. Signed-off-by: Tomasz Bursztyka <[email protected]>
Most of the time SPI devices use TI's frame format. But some may use
Motorola's. This is already taken care of in the SPI API and now it will
be possible to select the right format from DTS. Like:
...
frame-format = <SPI_FRAME_FORMAT_MOTOROLA>;
...
This is only meant to be used for devices supporting both formats (so
the format is not hard-coded in the driver) and selected by hardware
configuration or else. Which, in such case, it will need to use
DT_INST_PROP(<instance number>, frame-format) macro call to retrieve
the property value. Others can fully ignore it.
Signed-off-by: Tomasz Bursztyka <[email protected]>
tbursztyka
force-pushed
the
spi_motorola_ti
branch
from
e87d945 to
81e00c7
Compare
erwango
approved these changes
Nov 24, 2021
carlescufi
approved these changes
Nov 29, 2021
Contributor
|
@tbursztyka, could you please have a look at my PR #40860 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a configuration bit to switch between TI and Motorola frame formats.