Skip to content

Conversation

@cameled
Copy link
Contributor

@cameled cameled commented Nov 11, 2021

This PR based on #39958 work.

More GD32 related work? #38657

[EDIT]
TODO-List:

  • Add gd32f350 pinctrl to hal_gigadevice
  • support GD32F350R-EVAL board

@github-actions
Copy link

github-actions bot commented Nov 11, 2021

The following west manifest projects have been modified in this Pull Request:

Name Old Revision New Revision Diff
hal_gigadevice zephyrproject-rtos/hal_gigadevice@749fdd4 zephyrproject-rtos/hal_gigadevice@2eafc9d (main) zephyrproject-rtos/[email protected]

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@nandojve nandojve mentioned this pull request Nov 11, 2021
55 tasks
@nandojve nandojve changed the title add gd32f350 board support boards: arm: Introduce gd32f350r_eval board Nov 22, 2021
@cameled cameled force-pushed the gd32f350 branch 2 times, most recently from 427f4f7 to 9bd7e31 Compare November 30, 2021 07:51
@cameled cameled marked this pull request as ready for review November 30, 2021 07:51
Copy link
Member

@gmarull gmarull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, some minor nitpicks

Copy link
Member

@nandojve nandojve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @cameled ,

LGTM, few notes.

@cameled
Copy link
Contributor Author

cameled commented Dec 9, 2021

Hi @nashif, could you please help to review this PR, thanks!

Update the hal_gigadevice revirsion which support gd32f3x0 HAL.

Signed-off-by: HaiLong Yang <[email protected]>
Add CEC and TSI drivers from GD32F3X0.

Signed-off-by: HaiLong Yang <[email protected]>
@github-actions github-actions bot removed the DNM This PR should not be merged (Do Not Merge) label Dec 9, 2021
Copy link
Member

@nandojve nandojve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @cameled ,

Nice work! Just fix few minors.

@cameled cameled force-pushed the gd32f350 branch 2 times, most recently from 983c9ec to c21c8ae Compare December 10, 2021 10:39
@nandojve nandojve added this to the v3.0.0 milestone Dec 10, 2021
Add support for GigaDevice gd32f3x0 series.

Signed-off-by: HaiLong Yang <[email protected]>
Add support for GigaDevice GD32F3X0 series.

Signed-off-by: HaiLong Yang <[email protected]>
GD32 HAL use two USART status register name, USART_STAT and USART_STAT0.
This add a redefine to make USART_STAT as defaut name.

Signed-off-by: HaiLong Yang <[email protected]>
Add compile time check for gd32f350 gpio opspeed.

Signed-off-by: HaiLong Yang <[email protected]>
Add GD32F350R-EVAL board support on Zephyr.

Signed-off-by: HaiLong Yang <[email protected]>
@cameled
Copy link
Contributor Author

cameled commented Dec 13, 2021

Change gpiod address to lower case.

@cfriedt cfriedt merged commit 1b9e3be into zephyrproject-rtos:main Dec 14, 2021
@cameled cameled deleted the gd32f350 branch December 14, 2021 06:09
@str4t0m str4t0m added the platform: GD32 GigaDevice label Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants