drivers: counter: Added get_freq to API #40973
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nordic-krch
approved these changes
Dec 8, 2021
erwango
approved these changes
Dec 8, 2021
Optional counter API function which allows for a driver to determine counter frequency at runtime; if set, this supersedes whatever is set statically in the counter_config_info struct. Signed-off-by: Kent Hall <[email protected]>
kentjhall
force-pushed
the
counter-api-get-freq
branch
from
c3b4022 to
f7adb53
Compare
|
Note: force-pushed a re-dated commit (code unchanged) because one of the automated tests had failed without explanation. I suspect this must have been a bug, as the test now passes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optional counter API function which allows for a driver to determine counter
frequency at runtime; if set, this supersedes whatever is set statically in the
counter_config_info struct.
This is to address an issue which came up in my other PR #39414, where I was told that setting
freqin thecounter_config_infostruct at runtime is a bad idea; this remedy was suggested by @nordic-krch.If this goes through, I suggest drivers/counter/counter_imx_epit.c and drivers/counter/counter_mcux_ctimer.c be updated to use
get_freqas well, since they similarly updatefreqin their timer initialization routines.