Skip to content

Fix few missing memory region names on stm32 boards #41049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 10, 2021
Merged

Fix few missing memory region names on stm32 boards #41049

merged 3 commits into from
Dec 10, 2021

Conversation

@fabiobaltieri
Copy link
Member

@fabiobaltieri fabiobaltieri commented Dec 9, 2021 •
edited
Loading

Hey hi, found few missing region names after #37279 on SDRAM and CCM nodes for some stm32 boards. One had no compatible, the other missed the binding, tested with west build -p -b stm32f429i_disc1 samples/basic/blinky.

Before:

Memory region         Used Size  Region Size  %age Used
           FLASH:       14988 B         2 MB      0.71%
            SRAM:        4320 B       192 KB      2.20%
/memory@10000000:          0 GB        64 KB      0.00%
 /sdram@d0000000:          0 GB         8 MB      0.00%
        IDT_LIST:          0 GB         2 KB      0.00%

after:

Memory region         Used Size  Region Size  %age Used
           FLASH:       14988 B         2 MB      0.71%
            SRAM:        4320 B       192 KB      2.20%
             CCM:          0 GB        64 KB      0.00%
          SDRAM2:          0 GB         8 MB      0.00%
        IDT_LIST:          0 GB         2 KB      0.00%

Also fix the property name used in zephyr_linker_dts_memory, right now it's always using the fallback.

@JordanYates

@github-actions github-actions bot added area: Boards area: Devicetree area: Devicetree Binding PR modifies or adds a Device Tree binding platform: STM32 ST Micro STM32 labels Dec 9, 2021
@erwango erwango self-assigned this Dec 10, 2021
erwango
erwango requested changes Dec 10, 2021
View reviewed changes
Copy link
Member

@erwango erwango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @fabiobaltieri. Only minor comments

erwango
erwango reviewed Dec 10, 2021
View reviewed changes
boards/arm/stm32f769i_disco/stm32f769i_disco.dts Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at this (and not related to this PR):
@mbolivar-nordic: device_type prop is nowhere documented in bindings. Shouldn't it be removed ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious as well, shows up in edtlib.py but I don't think it's used anywhere and it's declared as deprecated in the specs https://github.com/devicetree-org/devicetree-specification/blob/main/source/chapter2-devicetree-basics.rst#device_type-deprecated.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's declared as deprecated in the specs https://github.com/devicetree-org/devicetree-specification/blob/main/source/chapter2-devicetree-basics.rst#device_type-deprecated.

@fabiobaltieri the link you pasted says (emphasis mine):

new use of the property is deprecated, and it should be included only on cpu and memory nodes for compatibility with IEEE 1275–derived devicetrees.

So from a specification point of view, it seems fine to keep this as is.

@galak asked about this on the spec mailing list, but the results were inconclusive: https://www.spinics.net/lists/devicetree-spec/msg00800.html

Take from that what you will.

@JordanYates JordanYates mentioned this pull request Dec 10, 2021
Closed
@fabiobaltieri
boards: stm32: set compatible and name for sdram nodes
8f21ed8 
Add the compatible property to the board level sdram nodes in few stm32
dts files so that the zephyr,memory-region name is used correctly in the
linker script.

Signed-off-by: Fabio Baltieri <[email protected]>
@fabiobaltieri
dts: bindings: stm32-ccm: use the mem-region property
257e06c 
Include the mem-region bindings for the stm32 ccm nodes and set the name
in the current dtsi files.

Signed-off-by: Fabio Baltieri <[email protected]>
@fabiobaltieri
cmake: use the correct property for the memory region name
9347d78 
Fix the zephyr_linker_dts_memory to lookup the correct property name
when trying to figre the region name.

Signed-off-by: Fabio Baltieri <[email protected]>
@MaureenHelm MaureenHelm merged commit c07d747 into zephyrproject-rtos:main Dec 10, 2021
@fabiobaltieri fabiobaltieri deleted the mem-reg-names branch December 10, 2021 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MaureenHelm MaureenHelm MaureenHelm approved these changes

@tejlmand tejlmand tejlmand approved these changes

@erwango erwango erwango approved these changes

@FRASTM FRASTM FRASTM approved these changes

@ABOSTM ABOSTM Awaiting requested review from ABOSTM

@galak galak Awaiting requested review from galak

@nashif nashif Awaiting requested review from nashif

+1 more reviewer

@mbolivar-nordic mbolivar-nordic mbolivar-nordic left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@erwango erwango

Labels

area: Boards area: Build System area: Devicetree Binding PR modifies or adds a Device Tree binding area: Devicetree platform: STM32 ST Micro STM32

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@fabiobaltieri @MaureenHelm @tejlmand @erwango @FRASTM @mbolivar-nordic