Skip to content

Conversation

@Delsian
Copy link
Contributor

@Delsian Delsian commented Dec 13, 2021

Each STM32H7 Series chip contains 2 or 3 FDCAN controllers.
(https://www.st.com/en/microcontrollers-microprocessors/
stm32h7-series.html)

@Delsian Delsian requested a review from erwango as a code owner December 13, 2021 14:42
@Delsian Delsian force-pushed the stm32h7_can branch 2 times, most recently from cd14b07 to 8144a0d Compare December 13, 2021 15:13
@alexanderwachter
Copy link
Member

Thank you for the addition!
Did you test this on a board?
I was told that there are modifications requited for the h7 series.

@Delsian
Copy link
Contributor Author

Delsian commented Dec 14, 2021

Did you test this on a board?

Just tried with new board. Unfortunately, unsuccessful:

zephyr/drivers/can/can_stm32fd.c:52:29: error: 'LL_RCC_FDCAN_CLKSOURCE_PCLK1' undeclared (first use in this function); did you mean 'LL_RCC_FDCAN_CLKSOURCE_PLL1Q'?                                                              

I will be glad for any suggestion, it's critical for me to run CAN on STM32H7
My DTS node:

&can1 {
	pinctrl-0 = <&fdcan1_rx_pa11 &fdcan1_tx_pa12>;
	pinctrl-names = "default";
	bus-speed = <125000>;
	bus-speed-data = <1000000>;
	sjw = <1>;
	sjw-data = <1>;
	prop-seg = <0>;
	phase-seg1 = <6>;
	phase-seg2 = <5>;
	status = "okay";
};

Each STM32H7 Series chip contains 2 or 3 FDCAN controllers.
(https://www.st.com/en/microcontrollers-microprocessors/
stm32h7-series.html)

Signed-off-by: Eug Krashtan <[email protected]>
Copy link
Member

@henrikbrixandersen henrikbrixandersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@alexanderwachter
Copy link
Member

@Delsian does it work now on your board?

@erwango erwango added the DNM This PR should not be merged (Do Not Merge) label Dec 17, 2021
@erwango
Copy link
Member

erwango commented Dec 17, 2021

Set as DNM to avoid merge before we have a proof that it's working

@Delsian
Copy link
Contributor Author

Delsian commented Dec 17, 2021

@alexanderwachter yesterday I got info from the factory: my hardware delays until the middle of January. So, maybe guys from ST (or anybody else) can test if they have boards with FDCAN?

@alexanderwachter
Copy link
Member

@Delsian I think you will at least need the following PR:
#41328

@Delsian
Copy link
Contributor Author

Delsian commented Dec 19, 2021

@Delsian I think you will at least need the following PR: #41328

Yes, thank you!

@erwango
Copy link
Member

erwango commented Dec 20, 2021

my hardware delays until the middle of January. So, maybe guys from ST (or anybody else) can test if they have boards with FDCAN?

@Delsian If you're pushing something on your own and for your need, the minimum would be that you are able to run it on your side. We can help for non regression or complementary testing when required, but a minimum basic functional testing is expected from the PR's author in any case.

@henrikbrixandersen
Copy link
Member

I suggest moving this to draft state until the functionality has been tested on hardware.

@JeremyBCD
Copy link
Contributor

@Delsian I have gotten CAN working on the STM32H7, checkout this PR: #41549

@henrikbrixandersen henrikbrixandersen self-requested a review January 4, 2022 23:06
@Delsian
Copy link
Contributor Author

Delsian commented Jan 5, 2022

@JeremyBCD Thank you!

@Delsian Delsian closed this Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: CAN area: Devicetree DNM This PR should not be merged (Do Not Merge) platform: STM32 ST Micro STM32

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants