Skip to content

tests: fix typos and misnamed platforms #41238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 17, 2021
Merged

tests: fix typos and misnamed platforms #41238

merged 1 commit into from
Dec 17, 2021

Conversation

@nashif
Copy link
Member

@nashif nashif commented Dec 15, 2021

Various obsolote and misnamed platfomrs in test filters theat went
undetected for a while.

Fixes #41222

Signed-off-by: Anas Nashif [email protected]

@github-actions github-actions bot added area: Kernel area: Samples Samples area: Tests Issues related to a particular existing or missing test labels Dec 15, 2021
@nashif nashif requested a review from PerMac December 15, 2021 16:14
@nashif nashif mentioned this pull request Dec 15, 2021
Closed
gopiotr
gopiotr suggested changes Dec 15, 2021
View reviewed changes
tests/subsys/storage/stream/stream_flash/testcase.yaml Outdated
Copy link
Contributor

@gopiotr gopiotr Dec 15, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I built and tested this test scenario on real hardware and it failed.
@hakonfam could you look at this test, before merge this change into main?

Copy link
Contributor

@hakonfam hakonfam Dec 16, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do

Copy link
Contributor

@hakonfam hakonfam Dec 16, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test passes locally on my HW (v2.0.1)

Copy link
Member

@PerMac PerMac Dec 16, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It also works on my local setup.

Copy link
Contributor

@gopiotr gopiotr Dec 16, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmmm, I was also checking on board v2.0.1 with Zephyr SDK: zephyr-sdk-0.13.1 and it still failed. I will check my nrfjprog version and other things, but if you wrote, that it works on yours boards I will no longer block this PR.
@hakonfam @PerMac - thanks for checking :)

@gopiotr gopiotr mentioned this pull request Dec 15, 2021
Closed
13 tasks
ruuddw
ruuddw requested changes Dec 16, 2021
View reviewed changes
Copy link
Member

@ruuddw ruuddw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, can you please change "em_starterkit_em7d_secure" into "em_starterkit_em7d" instead of removing?

@zephyrbot zephyrbot added area: IPC Inter-Process Communication area: Flash area: POSIX POSIX API Library area: Storage Storage subsystem area: TF-M ARM Trusted Firmware-M (TF-M) labels Dec 16, 2021
@carlocaione carlocaione mentioned this pull request Dec 16, 2021
Closed
@nashif
tests: fix typos and misnamed platforms
c247e7b 
Various obsolote and misnamed platfomrs in test filters theat went
undetected for a while.

Fixes zephyrproject-rtos#41222

Signed-off-by: Anas Nashif <[email protected]>
@nashif nashif requested a review from ruuddw December 17, 2021 14:24
@nashif nashif merged commit 05ecd46 into zephyrproject-rtos:main Dec 17, 2021
@nashif nashif deleted the t/platforms branch December 17, 2021 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hakonfam hakonfam hakonfam left review comments

@abrodkin abrodkin abrodkin left review comments

@SebastianBoe SebastianBoe SebastianBoe approved these changes

@ceolin ceolin ceolin approved these changes

@ruuddw ruuddw ruuddw approved these changes

@MaureenHelm MaureenHelm MaureenHelm approved these changes

@erwango erwango erwango approved these changes

@microbuilder microbuilder microbuilder approved these changes

@dcpleung dcpleung dcpleung approved these changes

@PerMac PerMac PerMac approved these changes

@andyross andyross Awaiting requested review from andyross

@pfalcon pfalcon Awaiting requested review from pfalcon

@arnopo arnopo Awaiting requested review from arnopo

@carlocaione carlocaione Awaiting requested review from carlocaione

@enjiamai enjiamai Awaiting requested review from enjiamai

@KangJianX KangJianX Awaiting requested review from KangJianX

@peter-mitsis peter-mitsis Awaiting requested review from peter-mitsis

+3 more reviewers

@YuguoWH YuguoWH YuguoWH left review comments

@nvlsianpu nvlsianpu nvlsianpu approved these changes

@gopiotr gopiotr gopiotr approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@carlocaione carlocaione

Labels

area: Flash area: IPC Inter-Process Communication area: Kernel area: POSIX POSIX API Library area: Samples Samples area: Storage Storage subsystem area: Tests Issues related to a particular existing or missing test area: TF-M ARM Trusted Firmware-M (TF-M)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

tests: remove not existing platforms from platform allow or integration_platform