Skip to content

drivers: can: stm32: initial CAN/CANFD support for STM32H7 #41549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 19, 2022
Merged

drivers: can: stm32: initial CAN/CANFD support for STM32H7 #41549

merged 3 commits into from
Jan 19, 2022

Conversation

@JeremyBCD
Copy link
Contributor

@JeremyBCD JeremyBCD commented Jan 3, 2022

Adds support for CAN/CANFD for the STM32H7 series. Tested working on NUCLEO-H753 and proprietary hardware.

Builds on the existing m_can driver, fixed some issues in the generic implementation.

@alexanderwachter
Copy link
Member

alexanderwachter commented Jan 3, 2022

Looks good, but we need to find some more generic way to handle the msg_ram addressing. The Bosch m_can (i.e. used in Microchip SAM) addresses the msg_sram like it is in the current implementation.

@JeremyBCD JeremyBCD force-pushed the stm32h7-fdcan branch 2 times, most recently from 9fc3b26 to 49d188d Compare January 3, 2022 23:33
@JeremyBCD
Copy link
Contributor Author

JeremyBCD commented Jan 3, 2022

Looks good, but we need to find some more generic way to handle the msg_ram addressing. The Bosch m_can (i.e. used in Microchip SAM) addresses the msg_sram like it is in the current implementation.

I've added options to choose between absolute (SAME-style) and relative (STM32H7 and NXP-style) addressing for Message RAM.

Based on what @henrikbrixandersen is doing in #35832, should be easy to slot in his #ifdef as well.

@henrikbrixandersen henrikbrixandersen self-requested a review January 3, 2022 23:38
@JeremyBCD JeremyBCD force-pushed the stm32h7-fdcan branch 2 times, most recently from 92bdf8c to ccd0196 Compare January 3, 2022 23:46
@JeremyBCD JeremyBCD mentioned this pull request Jan 3, 2022
Closed
erwango
erwango requested changes Jan 4, 2022
View reviewed changes
gmarull
gmarull requested changes Jan 4, 2022
View reviewed changes
@JeremyBCD
Copy link
Contributor Author

JeremyBCD commented Jan 11, 2022

I think that I've covered everything at this point, unless we're unhappy with the handling of message_ram addresses. Just finished adopting the clock_control API, believe that I've embraced that as much as is currently possible.

@erwango
Copy link
Member

erwango commented Jan 12, 2022

@henrikbrixandersen, @alexanderwachter, @gmarull can you have a new look ?

henrikbrixandersen
henrikbrixandersen requested changes Jan 12, 2022
View reviewed changes
Copy link
Member

@henrikbrixandersen henrikbrixandersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only two minor issues:

gmarull
gmarull reviewed Jan 12, 2022
View reviewed changes
@JeremyBCD
Copy link
Contributor Author

JeremyBCD commented Jan 12, 2022

Thanks @gmarull for your review!

henrikbrixandersen
henrikbrixandersen requested changes Jan 13, 2022
View reviewed changes
henrikbrixandersen
henrikbrixandersen requested changes Jan 13, 2022
View reviewed changes
henrikbrixandersen
henrikbrixandersen approved these changes Jan 13, 2022
View reviewed changes
Copy link
Member

@henrikbrixandersen henrikbrixandersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

mbolivar-nordic
mbolivar-nordic reviewed Jan 13, 2022
View reviewed changes
Copy link
Contributor

@mbolivar-nordic mbolivar-nordic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK on the binding

alexanderwachter
alexanderwachter requested changes Jan 16, 2022
View reviewed changes
Copy link
Member

@alexanderwachter alexanderwachter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for being pedantic.
Otherwise LGTM!

@JeremyBCD
drivers: can: m_can variant for STM32H7
b913fa6 
* New m_can driver variant for STM32H7, as it uses the complete m_can
register set.
* Fix definitions for CAN_MCAN_RXF0S_F0FL, CAN_MCAN_TXEFC_EFSA_POS.

Signed-off-by: Jeremy Wood <[email protected]>
@JeremyBCD
dts: add stm32h7 can binding and node
f55c5be 
* Add can peripheral to stm32h7.dtsi.
* Add binding for m_can stm32h7 driver.

Signed-off-by: Jeremy Wood <[email protected]>
@JeremyBCD
boards: arm: add can1 to nucleo_h743/753.
1534ea1 
* Enable and configure can1 for nucleo_h743/753.
* Update documentation.

Signed-off-by: Jeremy Wood <[email protected]>
@henrikbrixandersen henrikbrixandersen requested review from alexanderwachter and removed request for alexanderwachter and galak January 18, 2022 20:45
alexanderwachter
alexanderwachter approved these changes Jan 19, 2022
View reviewed changes
Copy link
Member

@alexanderwachter alexanderwachter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this work!

@nashif nashif merged commit 9d346cc into zephyrproject-rtos:main Jan 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@henrikbrixandersen henrikbrixandersen henrikbrixandersen approved these changes

@alexanderwachter alexanderwachter alexanderwachter approved these changes

@erwango erwango erwango approved these changes

@gmarull gmarull gmarull approved these changes

@FRASTM FRASTM FRASTM approved these changes

@ABOSTM ABOSTM Awaiting requested review from ABOSTM

@nashif nashif Awaiting requested review from nashif

@carlescufi carlescufi Awaiting requested review from carlescufi

@karstenkoenig karstenkoenig Awaiting requested review from karstenkoenig

@legoabram legoabram Awaiting requested review from legoabram

@martinjaeger martinjaeger Awaiting requested review from martinjaeger

@nixward nixward Awaiting requested review from nixward

@tejlmand tejlmand Awaiting requested review from tejlmand

@utzig utzig Awaiting requested review from utzig

+1 more reviewer

@mbolivar-nordic mbolivar-nordic mbolivar-nordic left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@erwango erwango

Labels

area: Boards area: Build System area: CAN area: Devicetree Binding PR modifies or adds a Device Tree binding area: Devicetree area: Documentation platform: STM32 ST Micro STM32

Projects

None yet

Milestone

v3.0.0

Development

Successfully merging this pull request may close these issues.

9 participants

@JeremyBCD @alexanderwachter @henrikbrixandersen @erwango @gmarull @FRASTM @mbolivar-nordic @nashif @zephyrbot