Sam0 adc fix #41853
Closed
Sam0 adc fix #41853
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area: ADC
In struct adc_sequence the channels member is a bitset specifying which channels to cover by the scan. The sam0 driver only supports one channel to be scanned at a time, but the check made until now did not regard .channels as a bitset but a number and thus only accepting a value of 1 aka channel 0 With this fix it is now checked whether more bits are set Signed-off-by: Kim Bøndergaard <[email protected]>
Some adc drivers, like adc_sam0, doesn't look at channel_id when setting up the adc channel, but rely on the input_positive and input_negative members. With this change the sample project also supports e.g. samd21 based boards using other pins than AIN[0]. This is exemplified by adding arduino_zero overlay using AIN[10] Signed-off-by: Kim Bøndergaard <[email protected]>
Member
Member
Contributor
Author
|
Seems like other PR's in the pipeline are fixing the issues solved by this PR so I'll retract this one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make support for all samd21 adc channels. Before only channel 0 was supported.
example project drivers/adc enriched with overlay for arduino_zero.
Unfortunately I don't have access to this board and can't verify it my self.
I'm currently working on another board on which the fix has been verified, but it would be nice if someone could test it at arduino_zero