Skip to content

Sam0 adc fix #41853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Sam0 adc fix #41853

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bb0e428
drivers: adc: adc_sam0: Allow all ADC channels to be used
KimBP Jan 16, 2022
989f680
sample: drivers: adc: Honnor CONFIG_ADC_CONFIGURABLE_INPUTS
KimBP Jan 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion drivers/adc/adc_sam0.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -392,7 +392,8 @@ static int start_read(const struct device *dev,

wait_synchronization(adc);

if (sequence->channels != 1U) {
if ((sequence->channels == 0) ||
((sequence->channels & (sequence->channels - 1)) != 0)) {
LOG_ERR("Channel scanning is not supported");
return -ENOTSUP;
}
Expand Down
16 changes: 16 additions & 0 deletions samples/drivers/adc/boards/arduino_zero.overlay
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
/*
* SPDX-License-Identifier: Apache-2.0
*
* Copyright (c) 2022 Kim Bøndergaard <[email protected]>
*/

/ {
zephyr,user {
/* J106.6 (A5) aka D21G18, pin PB02_AIN10 */
io-channels = <&adc 10>;
};
};

&adc {
status = "okay";
};
9 changes: 8 additions & 1 deletion samples/drivers/adc/src/main.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,11 @@ struct adc_channel_cfg channel_cfg = {
.acquisition_time = ADC_ACQUISITION_TIME,
/* channel ID will be overwritten below */
.channel_id = 0,
.differential = 0
.differential = 0,
#ifdef CONFIG_ADC_CONFIGURABLE_INPUTS
.input_negative = 0,
.input_positive = 0,
#endif
};

struct adc_sequence sequence = {
Expand Down Expand Up @@ -80,6 +84,9 @@ void main(void)
channel_cfg.input_positive = SAADC_CH_PSELP_PSELP_AnalogInput0
+ channel_ids[i];
#endif
#ifdef CONFIG_ADC_CONFIGURABLE_INPUTS
channel_cfg.input_positive = channel_ids[i];
#endif

adc_channel_setup(dev_adc, &channel_cfg);

Expand Down