drivers: can:can_mcan.h : add back macro NUM_TX_EVENT_FIFO_ELEMENTS #42294
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaced duplicate value of NUM_TX_BUF_ELEMENTS for tx_event_fifo. Signed-off-by: Pin Loon Lee <[email protected]>
To be used in DT_PROP(MCAN_DT_PATH, tx_event_fifo_elements) in can_mcan.h Signed-off-by: Pin Loon Lee <[email protected]>
Use same value of tx-buffer-elements for tx-event-fifo-elements. Signed-off-by: Pin Loon Lee <[email protected]>
pllee4
requested review from
alexanderwachter,
dleach02,
erwango,
galak and
mmahadevan108
as code owners
github-actions
bot
added
area: CAN
area: Devicetree
area: Devicetree Binding
Member
|
It's meant to be the same size. |
Member
Member
|
@pllee4 Not sure I understand the reasoning behind this PR. Do you have a need for explicitly specifying a Tx event FIFO size? |
Author
Author
From alexanderwachter, seems like this PR is not needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From can_mcan.h in zephyr-v2.7.1, there is helper macro for
NUM_TX_EVENT_FIFO_ELEMENTSwhich seems like should be used for size of can_mcan_tx_event_fifo tx_event_fifoNot sure whether that was a typo or meant to be using same size of
NUM_TX_BUF_ELEMENTSfor bothcan_mcan_tx_event_fifo tx_event_fifoandcan_mcan_tx_buffer tx_bufferThis pull request is just trying to add back the helper macro and add on the missing dts property for
tx-event-fifo-elementsThe value of
tx-event-fifo-elementsin .dtsi files is set to be the same withtx-buffer-elementsfor now to avoid unintended changesSigned-off-by: Pin Loon Lee [email protected]