Skip to content

boards: bl654_usb: use CDC ACM UART as serial backend #42371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 7, 2022
Merged

boards: bl654_usb: use CDC ACM UART as serial backend #42371

merged 2 commits into from
Feb 7, 2022

Conversation

@jfischer-no
Copy link
Contributor

@jfischer-no jfischer-no commented Feb 1, 2022 •
edited
Loading

usb: add option to initialize USB device support at boot

This patch adds new board specific Kconfig option
BL654_USB_SERIAL_BACKEND_CDCACM, which is enabled by
default except USB_DEVICE_BLUETOOTH class is used.
Applications that depend on usb_enable() or do not
require composite configuration cannot be used
with BL654 USB board without user intervention.

Fixes: #39904

@jfischer-no jfischer-no added this to the v3.0.0 milestone Feb 1, 2022
carlescufi
carlescufi requested changes Feb 2, 2022
View reviewed changes
subsys/usb/usb_device.c Outdated
Copy link
Member

@carlescufi carlescufi Feb 2, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do you need this if statement?

Copy link
Contributor Author

@jfischer-no jfischer-no Feb 2, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(⊙.☉)7, probably c&p

@nordicjm
Copy link
Contributor

nordicjm commented Feb 2, 2022

This doesn't solve the issue if users still need to supply a random Kconfig when building projects. #39987 fixes this without needing user intervention and providing an easy user experience

@jfischer-no
Copy link
Contributor Author

jfischer-no commented Feb 2, 2022

This doesn't solve the issue if users still need to supply a random Kconfig when building projects. #39987 fixes this without needing user intervention and providing an easy user experience

According to my understanding it is not possible and I have tried to explain it to you several times. Probably I am missing something, can you explain to me in what miraculous way it happens that option CONFIG_BOARD_ENABLE_USB_AUTOMATICALLY in #39987 is activated?

@nordicjm
Copy link
Contributor

nordicjm commented Feb 2, 2022 •
edited
Loading

This doesn't solve the issue if users still need to supply a random Kconfig when building projects. #39987 fixes this without needing user intervention and providing an easy user experience

According to my understanding it is not possible and I have tried to explain it to you several times. Probably I am missing something, can you explain to me in what miraculous way it happens that option CONFIG_BOARD_ENABLE_USB_AUTOMATICALLY in #39987 is activated?

I built an application and it worked, so going off that which I also explained to you several times, yes, it is possible and works.

config USB_UART_CONSOLE
	default y if !USB_DEVICE_BLUETOOTH

config BOARD_ENABLE_USB_AUTOMATICALLY
	bool "Enable USB automatically"
	default y if USB_UART_CONSOLE

If USB_DEVICE_BLUETOOTH is not set, then USB_UART_CONSOLE is set, if this is set then BOARD_ENABLE_USB_AUTOMATICALLY is set which then enables USB automatically at startup without any Kconfigs being specified in the build options via command line

@zephyrbot zephyrbot added the platform: nRF Nordic nRFx label Feb 2, 2022
@zephyrbot zephyrbot requested a review from anangl February 2, 2022 14:05
@jfischer-no
usb: add option to initialize USB device support at boot
951633e 
Possibility to initialize USB device support is useful when
only CDC ACM class is enabled and CDC ACM UART is used as
backend for console, shell, or logging.

Signed-off-by: Johann Fischer <[email protected]>
@jfischer-no
boards: bl654_usb: use CDC ACM UART as serial backend
b7856d7 
This patch adds new board specific Kconfig option
BL654_USB_SERIAL_BACKEND_CDCACM, which is enabled by
default except USB_DEVICE_BLUETOOTH class is used.
Applications that depend on usb_enable() or do not
require composite configuration cannot be used
with BL654 USB board without user intervention.

Signed-off-by: Johann Fischer <[email protected]>
@jfischer-no jfischer-no force-pushed the pr-workaround-serial-backend-for-boards-like-nrf52840dongle branch from 1c723f0 to b7856d7 Compare February 3, 2022 10:24
@jfischer-no
Copy link
Contributor Author

jfischer-no commented Feb 3, 2022 

config USB_UART_CONSOLE
	default y if !USB_DEVICE_BLUETOOTH

config BOARD_ENABLE_USB_AUTOMATICALLY
	bool "Enable USB automatically"
	default y if USB_UART_CONSOLE

If USB_DEVICE_BLUETOOTH is not set, then USB_UART_CONSOLE is set, if this is set then BOARD_ENABLE_USB_AUTOMATICALLY is set which then enables USB automatically at startup without any Kconfigs being specified in the build options via command line

There is no USB_UART_CONSOLE, but assuming it describes exact behavior desired by you, it is the same as:

config BOARD_ENABLE_USB_AUTOMATICALLY
	bool "Enable USB automatically"
	default y if !USB_DEVICE_BLUETOOTH

or with 951633e,

config BL654_USB_SERIAL_BACKEND_CDCACM
	bool "Use CDC ACM UART as backend for BL654 USB adapter"
	default y if !USB_DEVICE_BLUETOOTH
	help
	  Use CDC ACM UART as backend for console or shell.

if BL654_USB_SERIAL_BACKEND_CDCACM

config USB_DEVICE_INITIALIZE_AT_BOOT
	default y

...

endif #BL654_USB_SERIAL_BACKEND_CDCACM

Is it correct so far? If yes please approve and accept the resulting disadvantages.

@jfischer-no jfischer-no changed the title boards like nrf52840dongle: use CDC ACM UART as serial backend boards: bl654_usb: use CDC ACM UART as serial backend Feb 4, 2022
@carlescufi carlescufi merged commit 9e4968b into zephyrproject-rtos:main Feb 7, 2022
@zephyrbot zephyrbot mentioned this pull request Feb 7, 2022
Closed
@nordicjm nordicjm mentioned this pull request Mar 16, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@carlescufi carlescufi carlescufi approved these changes

@nordicjm nordicjm nordicjm approved these changes

@galak galak Awaiting requested review from galak

@MaureenHelm MaureenHelm Awaiting requested review from MaureenHelm

@anangl anangl Awaiting requested review from anangl

Assignees

@anangl anangl

Labels

area: Boards area: Console area: Devicetree area: Shell Shell subsystem area: USB Universal Serial Bus platform: nRF Nordic nRFx

Projects

None yet

Milestone

v3.0.0

Development

Successfully merging this pull request may close these issues.

bl654_usb does not work with hci_usb sample application

5 participants

@jfischer-no @nordicjm @carlescufi @anangl @zephyrbot