Stm32f429i disc1 LTDC & Display #44533
Conversation
papadkostas
requested review from
ABOSTM,
FRASTM,
MaureenHelm,
erwango,
galak and
nashif
as code owners
github-actions
bot
added
area: Boards
area: Devicetree
area: Devicetree Binding
papadkostas
force-pushed
the
stm32f429i_disc1-display
branch
3 times, most recently
from
5c539ab to
70656c4
Compare
zephyrbot
requested review from
GTLin08,
brockus-zephyr,
gmarull,
jackrosenthal,
jfischer-no,
keith-zephyr,
mbolivar-nordic,
sjg20 and
yperess
There was a problem hiding this comment.
this commit 09f8518 is doing too many changes:
- changing display to ili9341
- changing clock speeds
- changing pinctrl settings
...
please split into individual commits explaining the rationale of the change
There was a problem hiding this comment.
I did so because all changes were made targeting the display support, except boosting clock speed.
Will do as requested.
drivers/display/display_stm32_ltdc.c
Outdated
There was a problem hiding this comment.
formatting looks wrong here.
for readability I'd avoid ifdeffing in between arguments.
There was a problem hiding this comment.
Should I just rewrite twice the if defined for both F4 and F7 targets?
There was a problem hiding this comment.
This is not required. Alternatively, you can use a constant defined externally.
Anyway, I hope we'll be able to get rid of this part soon and use clock_control api to do this (see #42097)
There was a problem hiding this comment.
this and others: there's no need to re-define type. this file just changes defaults.
There was a problem hiding this comment.
this should not be needed. doesn't ltdc driver default to y if its DT node is okay?
There was a problem hiding this comment.
this should be updated in the commit that updates clock settings
There was a problem hiding this comment.
why is this needed? should again have its own commit
papadkostas
force-pushed
the
stm32f429i_disc1-display
branch
from
70656c4 to
42d46ca
Compare
papadkostas
force-pushed
the
stm32f429i_disc1-display
branch
2 times, most recently
from
a26eb7d to
87ff3f4
Compare
This enables the option through dts to drive the display with RGB interface. Signed-off-by: Konstantinos Papadopoulos <[email protected]>
Onboard display is actually an ILI9341. It is connected to SPI5 which is shared with L3GD20. Max clock is set as described in BSP driver files (stm32f429i_discovery.c@638). ILI9341 configuration updated to enable RGB interface use. Signed-off-by: Konstantinos Papadopoulos <[email protected]>
Enable LTDC interface to drive the ILI9341 in RGB mode. Signed-off-by: Konstantinos Papadopoulos <[email protected]>
This commit fixes the clock control for LTDC peripheral Signed-off-by: Konstantinos Papadopoulos <[email protected]>
LTDC clock on F4/F7 series, is generated from PLLSAI which yet is not implemented into Zephyr. Signed-off-by: Konstantinos Papadopoulos <[email protected]>
Added required config for the display operation and default display name to "LTDC" for LVGL subsystem when the peripheral LTDC is used. Signed-off-by: Konstantinos Papadopoulos <[email protected]>
MaureenHelm
force-pushed
the
stm32f429i_disc1-display
branch
from
629f151 to
34c6ea7
Compare
7 participants
As LTDC is now working #43965 , I enabled support for F429.
I'm thinking of creating a 2 separate configuration files, one with graphic stuff enabled, and one without and also create a board/Kconfig file so that the options would be located within menuconfig in Board options section.
Later I'll push the driver for STMPE811 for the touch controller after this is ok.